[jira] Updated: (DERBY-4608) Unnecessary conversion of binary values to strings in SQLBinary.compare()

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-4608:
--------------------------------------

    Attachment: isnull.diff

The attached patch makes SQLBinary.compare() use isNull() instead of getString(). It also changes the HeapScan performance test so that it can run tests with binary strings instead of character strings, and adds a test case that uses predicates. When running the test case with predicates on binary data, the fix in SQLBinary reduces the time per iteration from 30 seconds to 5-6 seconds on my laptop.

Running the full regression test suite now.

> Unnecessary conversion of binary values to strings in SQLBinary.compare()
> -------------------------------------------------------------------------
>
>                 Key: DERBY-4608
>                 URL: https://issues.apache.org/jira/browse/DERBY-4608
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.5.3.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: isnull.diff
>
>
> SQLBinary.compare(int,DataValueDescriptor,boolean,boolean) converts the values to strings in order to check whether any of them are null. The isNull() method should be used instead to prevent the unnecessary conversion to strings.
> See this thread on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/201003.mbox/%3C001801cad09b$09aef650$1d0ce2f0$@ru%3E

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.