[GitHub] [incubator-doris] imay commented on a change in pull request #2737: Support replication_num setting for table level

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2737: Support replication_num setting for table level
URL: https://github.com/apache/incubator-doris/pull/2737#discussion_r365519791
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/SingleRangePartitionDesc.java
 ##########
 @@ -87,15 +87,13 @@ public short getReplicationNum() {
         return this.properties;
     }
 
-    public void analyze(int partColNum, Map<String, String> otherProperties) throws AnalysisException {
+    public void analyze(int partColNum, Map<String, String> otherProperties, Short replicationNum) throws AnalysisException {
 
 Review comment:
   I don't think it is a good way to analyze this class with a input replicationNum. It is up to the caller to decide how to use this object.
   If we do this through input arguments, there will be too many arguments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org