[jira] [Commented] (AIRFLOW-6530) Allow for custom Statsd client

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059804#comment-17059804 ] 

ASF GitHub Bot commented on AIRFLOW-6530:
-----------------------------------------

kaxil commented on pull request #7227: [AIRFLOW-6530] Allow Custom Statsd Client
URL: https://github.com/apache/airflow/pull/7227
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow for custom Statsd client
> ------------------------------
>
>                 Key: AIRFLOW-6530
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6530
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: scheduler, webserver
>    Affects Versions: 1.10.7
>            Reporter: Usman Arshad
>            Assignee: Usman Arshad
>            Priority: Major
>              Labels: features
>             Fix For: 1.10.10
>
>
> We are currently using Airflow at Skyscanner and we have a custom implementation of Statsd which offers features which wires in nicely into our metrics platform/tooling.
> I'm quite sure that other companies who are using Airflow would also find great benefit in being able to utilise their own custom Statsd client, therefore i am proposing this addition.
>  
> The proposed solution looks something along the lines of changing this:
> {code:java}
> statsd = StatsClient(
>     host=conf.get('scheduler', 'statsd_host'),
>     port=conf.getint('scheduler', 'statsd_port'),
>     prefix=conf.get('scheduler', 'statsd_prefix'))
> {code}
>  Into
> {code:java}
> statsd = conf.get('STATSD_CLIENT') or StatsClient(
>     host=conf.get('scheduler', 'statsd_host'),
>     port=conf.getint('scheduler', 'statsd_port'),
>     prefix=conf.get('scheduler', 'statsd_prefix'))
> {code}
> Note: Psuedocode, not actual code
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)