[jira] [Commented] (SOLR-4629) Stronger standard replication testing.

["Mark Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620493#comment-13620493 ] 

Mark Miller commented on SOLR-4629:
-----------------------------------

Looks good to me.

bq. is having this option a bad idea? should we document it or keep it hidden for tests?

It seems fine to me, but it seems safer to not advertise initially. No demand yet anyway. I'd doc it as subject to change and unsupported myself. 

bq.  i think we could probably speed up TestReplicationhandler 

+1
                
> Stronger standard replication testing.
> --------------------------------------
>
>                 Key: SOLR-4629
>                 URL: https://issues.apache.org/jira/browse/SOLR-4629
>             Project: Solr
>          Issue Type: Test
>          Components: replication (java)
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.3, 5.0, 4.2.1
>
>         Attachments: SOLR-4629_emptycommittest_and_numfoundrefactor_and_waitparam.patch
>
>
> I added to these tests recently, but there is a report on the list indicating we may still be missing something. Most reports have been positive so far after the 4.2 fixes, but I'd feel better after adding some more testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org