You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/17 13:03:57 UTC

[GitHub] [solr] janhoy opened a new pull request #532: SOLR-15862 Move solr/LICENSE.txt and SOLR/NOTICE.txt to git top-level

janhoy opened a new pull request #532:
URL: https://github.com/apache/solr/pull/532


   Adapt build to pick the license from there,
   Adapt smokeTester to expect right set of files in root vs solr/
   
   https://issues.apache.org/jira/browse/SOLR-15862
   
   It is a requirement to have license and notice files on top-level. Like we did for Lucene-build I'm not moving these up. I tested with `gradlew dev` and confirmed that binary release works and contains the correct files.
   
   I know that we need a total cleanup of both these files as well
   * move lots of (C) notices from NOTICE to LICENSE file
   * Cross-check that we list all dependencies, and that removed deps (such as for DIH etc) are removed from NOTICE/LICENSE
   
   I thought there was a separate JIRA for that, but I cannot find it now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] janhoy commented on a change in pull request #532: SOLR-15862 Move solr/LICENSE.txt and SOLR/NOTICE.txt to git top-level

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #532:
URL: https://github.com/apache/solr/pull/532#discussion_r786291182



##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -22,7 +22,7 @@ subprojects {
     // per-project.
     def title = "Apache Solr Search Server: ${project.name}"
     def implementationTitle = "org.apache.solr"
-    def legaleseDir = project(":solr").projectDir
+    def legaleseDir = getRootProject().projectDir

Review comment:
       Done

##########
File path: solr/packaging/build.gradle
##########
@@ -92,13 +92,16 @@ distributions {
     contents {
       // TODO: This is missing module README files, as compared to 8x
 
+      from(rootProject.projectDir, {

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] dweiss commented on a change in pull request #532: SOLR-15862 Move solr/LICENSE.txt and SOLR/NOTICE.txt to git top-level

Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #532:
URL: https://github.com/apache/solr/pull/532#discussion_r786099863



##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -22,7 +22,7 @@ subprojects {
     // per-project.
     def title = "Apache Solr Search Server: ${project.name}"
     def implementationTitle = "org.apache.solr"
-    def legaleseDir = project(":solr").projectDir
+    def legaleseDir = getRootProject().projectDir

Review comment:
       just rootDir I think is enough.
   https://docs.gradle.org/current/dsl/org.gradle.api.Project.html#org.gradle.api.Project:rootDir

##########
File path: solr/packaging/build.gradle
##########
@@ -92,13 +92,16 @@ distributions {
     contents {
       // TODO: This is missing module README files, as compared to 8x
 
+      from(rootProject.projectDir, {

Review comment:
       Could be rootDir or this, fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] janhoy merged pull request #532: SOLR-15862 Move solr/LICENSE.txt and SOLR/NOTICE.txt to git top-level

Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #532:
URL: https://github.com/apache/solr/pull/532


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org