You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/28 16:46:15 UTC

[GitHub] [druid] liam-verta commented on a diff in pull request #13153: Upgrade to Calcite 1.32.0

liam-verta commented on code in PR #13153:
URL: https://github.com/apache/druid/pull/13153#discussion_r982637242


##########
sql/pom.xml:
##########
@@ -339,6 +338,47 @@
           </execution>
         </executions>
       </plugin>
+      <!-- <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-antrun-plugin</artifactId>
+        <version>3.1.0</version>
+        <executions>
+          <execution>
+            <id>generate-fmpp-sources</id>
+            <phase>generate-sources</phase>
+            <configuration>
+              <target>
+                <taskdef name="fmpp" classname="fmpp.tools.AntTask" classpath="maven.plugin.classpath" />
+                <fmpp sourceRoot="${project.build.directory}/codegen/templates"
+                  outputRoot="${project.build.directory}/generated-sources/annotations"
+                  configuration="${project.build.directory}/codegen/config.fmpp"
+                  />
+              </target>
+            </configuration>
+            <goals>
+              <goal>run</goal>
+            </goals>
+          </execution>
+        </executions>
+        <dependencies>
+          <dependency>
+            <groupId>net.sourceforge.fmpp</groupId>
+            <artifactId>fmpp</artifactId>
+            <version>0.9.16</version>
+            <exclusions>
+              <exclusion>
+                <groupId>ant</groupId>
+                <artifactId>ant</artifactId>
+              </exclusion>
+            </exclusions>
+          </dependency>
+          <dependency>
+            <groupId>org.freemarker</groupId>
+            <artifactId>freemarker</artifactId>
+            <version>2.3.31</version>
+          </dependency>
+        </dependencies>
+      </plugin> -->

Review Comment:
   ```suggestion                  
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org