You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Maximilian Michels <mx...@apache.org> on 2019/08/28 12:21:31 UTC
Master broken (likely due to Mockito upgrade)
Hi,
Most of you probably realized that the master is currently broken:
https://builds.apache.org/job/beam_PreCommit_Java_Commit/7505/
https://builds.apache.org/job/beam_PreCommit_Java_Cron/
I did some bisecting and found that Mockito was updated:
https://github.com/apache/beam/pull/9338
This was merged 7 days ago. I don' know why we are now seeing these
errors now, but testing this locally I was able to reproduce the errors
with master and they were gone after reverting the Mockito changes. I
opened up a PR with a revert: https://github.com/apache/beam/pull/9441
Thanks,
Max
Re: Master broken (likely due to Mockito upgrade)
Posted by Maximilian Michels <mx...@apache.org>.
Master is ok again. Thank you Ryan for this one: https://github.com/apache/beam/pull/9442
On 28.08.19 14:32, Maximilian Michels wrote:
> Ismael pointed out that reverting #9338 works but the real culprit is
> https://github.com/apache/beam/pull/9000. Updated the PR to revert this
> commit instead.
>
> -Max
>
> On 28.08.19 14:21, Maximilian Michels wrote:
> > Hi,
> >
> > Most of you probably realized that the master is currently broken:
> > https://builds.apache.org/job/beam_PreCommit_Java_Commit/7505/
> > https://builds.apache.org/job/beam_PreCommit_Java_Cron/
> >
> > I did some bisecting and found that Mockito was updated:
> > https://github.com/apache/beam/pull/9338
> >
> > This was merged 7 days ago. I don' know why we are now seeing these
> > errors now, but testing this locally I was able to reproduce the errors
> > with master and they were gone after reverting the Mockito changes. I
> > opened up a PR with a revert: https://github.com/apache/beam/pull/9441
> >
> > Thanks,
> > Max
> >
>
Re: Master broken (likely due to Mockito upgrade)
Posted by Maximilian Michels <mx...@apache.org>.
Ismael pointed out that reverting #9338 works but the real culprit is https://github.com/apache/beam/pull/9000. Updated the PR to revert this commit instead.
-Max
On 28.08.19 14:21, Maximilian Michels wrote:
> Hi,
>
> Most of you probably realized that the master is currently broken:
> https://builds.apache.org/job/beam_PreCommit_Java_Commit/7505/
> https://builds.apache.org/job/beam_PreCommit_Java_Cron/
>
> I did some bisecting and found that Mockito was updated:
> https://github.com/apache/beam/pull/9338
>
> This was merged 7 days ago. I don' know why we are now seeing these
> errors now, but testing this locally I was able to reproduce the errors
> with master and they were gone after reverting the Mockito changes. I
> opened up a PR with a revert: https://github.com/apache/beam/pull/9441
>
> Thanks,
> Max
>