You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/11/28 20:47:48 UTC

[I] Unify `Expr::AggregateFunction` and `Expr::AggregateUDF` [arrow-datafusion]

alamb opened a new issue, #8346:
URL: https://github.com/apache/arrow-datafusion/issues/8346

   ### Is your feature request related to a problem or challenge?
   
   Part of  https://github.com/apache/arrow-datafusion/issues/8045 we are working
   to consolidate the function implementation in DataFusion to make it easier to
   manage DataFusion's built in list of functions as well as ensure user defined
   and built in functions have the same feature sets.
   
   I think it is also important to keep the Expr representation consistent for
   Aggregate and Window functions to make DataFusion easier to work with, as well
   as to permit eventually applying the same unification of built in and user
   defined functions to aggregates and window functions.
   
   
   
   ### Describe the solution you'd like
   
   I would like to `Expr::AggregateFunction` and `Expr::AggregateUDF` following the pattern in https://github.com/apache/arrow-datafusion/pull/8258 @2010YOUY01:
   
   1. Remove  `Expr::AggregateUDF`
   2. Add an `AggregateFunctionDefinition` that mirrors `ScalarFunctionDefinition`
   3. Update `Expr::AggregateFunction` so that it is used for both built in and user defined functions
   4. Update the code to use these new APIs
   
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   I think this is a pretty good first issue because we have an existing pattern in https://github.com/apache/arrow-datafusion/pull/8258 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Unify `Expr::AggregateFunction` and `Expr::AggregateUDF` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #8346:  Unify `Expr::AggregateFunction` and `Expr::AggregateUDF`
URL: https://github.com/apache/arrow-datafusion/issues/8346


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Unify `Expr::AggregateFunction` and `Expr::AggregateUDF` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8346:
URL: https://github.com/apache/arrow-datafusion/issues/8346#issuecomment-1831770975

   Thank you @Weijun-H 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Unify `Expr::AggregateFunction` and `Expr::AggregateUDF` [arrow-datafusion]

Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on issue #8346:
URL: https://github.com/apache/arrow-datafusion/issues/8346#issuecomment-1831516712

   I will take this ticket


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org