[GitHub] [pulsar] lsy180829 commented on a change in pull request #5632: [Issue 5614] Deprecate brokerServicePurgeInactiveFrequencyInSeconds

[GitBox <gi...@apache.org>]

lsy180829 commented on a change in pull request #5632: [Issue 5614] Deprecate brokerServicePurgeInactiveFrequencyInSeconds
URL: https://github.com/apache/pulsar/pull/5632#discussion_r347782089
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 ##########
 @@ -253,7 +253,7 @@
         category = CATEGORY_POLICIES,
         doc = "How often to check for inactive topics"
     )
-    private long brokerDeleteInactiveTopicsFrequencySeconds = 60;
+    private int brokerDeleteInactiveTopicsFrequencySeconds = 60;
 
 Review comment:
   https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L406,L410
   Cause of these lines, if I use 'long' , there will be an incompatible type. 
   Or, change the related method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services