[GitHub] [arrow] lidavidm commented on a change in pull request #10166: ARROW-11929: [C++][Dataset][Compute] Promote expression to the compute namespace

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #10166:
URL: https://github.com/apache/arrow/pull/10166#discussion_r620591026



##########
File path: cpp/examples/arrow/dataset_documentation_example.cc
##########
@@ -20,9 +20,9 @@
 
 #include <arrow/api.h>
 #include <arrow/compute/cast.h>
+#include <arrow/compute/exec/expression.h>

Review comment:
       I'll follow up and adjust the line numbers in the corresponding reST file (and see if I can figure out a better way to excerpt code snippets than hardcoding line numbers).

##########
File path: cpp/src/arrow/dataset/file_parquet_test.cc
##########
@@ -130,6 +130,10 @@ class TestParquetFileFormat : public FileFormatFixtureMixin<ParquetFormatHelper>
     return Batches(std::move(scan_task_it));
   }
 
+  void SetFilter(compute::Expression filter) {
+    ASSERT_OK_AND_ASSIGN(opts_->filter, filter.Bind(*opts_->dataset_schema));
+  }
+

Review comment:
       This is already in test_util.h.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org