You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/21 10:56:20 UTC
[GitHub] [camel] dk2k opened a new pull request #5856: Proposed changes to allow specify an instance of KeyStore explicitly
dk2k opened a new pull request #5856:
URL: https://github.com/apache/camel/pull/5856
Proposed changes (not a bug fix).
Why do I think they are needed?
- I think it's useful to allow user to construct a KeyStore using certificates and private keys programmatically
- I have issues reading a keystore in a gradle project from a KS file which is stored within my JAR file - I blame the existing code, which reads the file using resource field. Of course I can read KS file from file system, but it's less convenient. I need means to read KS file myself and pass an instance of KeyStore.
Backward compatibility is ensured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] dk2k commented on pull request #5856: Proposed changes to allow specify an instance of KeyStore explicitly
Posted by GitBox <gi...@apache.org>.
dk2k commented on pull request #5856:
URL: https://github.com/apache/camel/pull/5856#issuecomment-885516517
Removed warning message.
As for unit tests. My changes do not introduce any new functionality and I don't think any relevant tests can be added. If user decides to specify his own KeyStore (creation of an instance of keystore is well documented and has about 10 detailed exceptions), it's their responsibility to have this instance properly filled. I don't have any idea on the content of this Keystore. It's sort of inversion of control aka dependency injection.
I don't change the way this KeyStore is treated in the code of camel-api modile.
I seen an analogy from hibernate - specify DataSource. Imagine that previously you could only specify a path in file system to a file with dataSource properties. And now you can construct an instance of DataSource yourself and pass it into hibernate. What can be additionally tested here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5856: Proposed changes to allow specify an instance of KeyStore explicitly
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5856:
URL: https://github.com/apache/camel/pull/5856#issuecomment-885496511
I dont like the WARN logging - its not a standard we use in Camel. If you have configued to use that keystore explict then that is used as-is.
Can you add more javadoc, and it would also be good to have an unit test, since this is code in the core, and therefore we must have a high standard for test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5856: Proposed changes to allow specify an instance of KeyStore explicitly
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5856:
URL: https://github.com/apache/camel/pull/5856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org