You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Amar3tto (via GitHub)" <gi...@apache.org> on 2025/09/29 13:47:57 UTC
[PR] Fix PerformanceTests jobs [beam]
Amar3tto opened a new pull request, #36315:
URL: https://github.com/apache/beam/pull/36315
Fixes #36308, Fixes #36307, Fixes #33393
Successful run: https://github.com/apache/beam/actions/runs/18099081442/job/51497058278
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PerformanceTests jobs [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36315:
URL: https://github.com/apache/beam/pull/36315#discussion_r2388693172
##########
.test-infra/kubernetes/postgres/postgres-service-for-local-dev.yml:
##########
@@ -43,13 +43,26 @@ spec:
labels:
name: postgres
spec:
+ securityContext:
+ fsGroup: 999
containers:
- name: postgres
image: postgres
env:
- name: POSTGRES_PASSWORD
value: uuinkks
- name: PGDATA
- value: /var/lib/postgresql/data/pgdata
+ value: /pgdata/data
ports:
- containerPort: 5432
+ securityContext:
Review Comment:
Could you help me understand what this PR is doing? What problem is this solving, and what impact does this config have?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PerformanceTests jobs [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on code in PR #36315:
URL: https://github.com/apache/beam/pull/36315#discussion_r2388774354
##########
.test-infra/kubernetes/postgres/postgres-service-for-local-dev.yml:
##########
@@ -43,13 +43,26 @@ spec:
labels:
name: postgres
spec:
+ securityContext:
+ fsGroup: 999
containers:
- name: postgres
image: postgres
env:
- name: POSTGRES_PASSWORD
value: uuinkks
- name: PGDATA
- value: /var/lib/postgresql/data/pgdata
+ value: /pgdata/data
ports:
- containerPort: 5432
+ securityContext:
Review Comment:
The root problem was `mkdir: cannot create directory ‘/var/lib/postgresql/data’: Permission denied`.
It possibly came from new version of the postgres image.
I added more permissions and changed the path for pgdata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PerformanceTests jobs [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on code in PR #36315:
URL: https://github.com/apache/beam/pull/36315#discussion_r2388774354
##########
.test-infra/kubernetes/postgres/postgres-service-for-local-dev.yml:
##########
@@ -43,13 +43,26 @@ spec:
labels:
name: postgres
spec:
+ securityContext:
+ fsGroup: 999
containers:
- name: postgres
image: postgres
env:
- name: POSTGRES_PASSWORD
value: uuinkks
- name: PGDATA
- value: /var/lib/postgresql/data/pgdata
+ value: /pgdata/data
ports:
- containerPort: 5432
+ securityContext:
Review Comment:
The root problem was `mkdir: cannot create directory ‘/var/lib/postgresql/data’: Permission denied`.
It possibly came from the new version of the `postgres` image.
I added more permissions and changed the path for `pgdata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PerformanceTests jobs [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #36315:
URL: https://github.com/apache/beam/pull/36315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PerformanceTests jobs [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36315:
URL: https://github.com/apache/beam/pull/36315#discussion_r2389010553
##########
.test-infra/kubernetes/postgres/postgres-service-for-local-dev.yml:
##########
@@ -43,13 +43,26 @@ spec:
labels:
name: postgres
spec:
+ securityContext:
+ fsGroup: 999
containers:
- name: postgres
image: postgres
env:
- name: POSTGRES_PASSWORD
value: uuinkks
- name: PGDATA
- value: /var/lib/postgresql/data/pgdata
+ value: /pgdata/data
ports:
- containerPort: 5432
+ securityContext:
Review Comment:
Got it. This seems fine to me since it is all local anyways.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PerformanceTests jobs [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36315:
URL: https://github.com/apache/beam/pull/36315#issuecomment-3347988172
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PerformanceTests jobs [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on code in PR #36315:
URL: https://github.com/apache/beam/pull/36315#discussion_r2388774354
##########
.test-infra/kubernetes/postgres/postgres-service-for-local-dev.yml:
##########
@@ -43,13 +43,26 @@ spec:
labels:
name: postgres
spec:
+ securityContext:
+ fsGroup: 999
containers:
- name: postgres
image: postgres
env:
- name: POSTGRES_PASSWORD
value: uuinkks
- name: PGDATA
- value: /var/lib/postgresql/data/pgdata
+ value: /pgdata/data
ports:
- containerPort: 5432
+ securityContext:
Review Comment:
The root problem was `mkdir: cannot create directory ‘/var/lib/postgresql/data’: Permission denied`.
It possibly came from the new version of the `postgres` image.
I changed permissions for postgres user and changed the path for `pgdata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PerformanceTests jobs [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on code in PR #36315:
URL: https://github.com/apache/beam/pull/36315#discussion_r2388774354
##########
.test-infra/kubernetes/postgres/postgres-service-for-local-dev.yml:
##########
@@ -43,13 +43,26 @@ spec:
labels:
name: postgres
spec:
+ securityContext:
+ fsGroup: 999
containers:
- name: postgres
image: postgres
env:
- name: POSTGRES_PASSWORD
value: uuinkks
- name: PGDATA
- value: /var/lib/postgresql/data/pgdata
+ value: /pgdata/data
ports:
- containerPort: 5432
+ securityContext:
Review Comment:
The root problem was `mkdir: cannot create directory ‘/var/lib/postgresql/data’: Permission denied`.
It possibly came from the new version of the `postgres` image.
I changed the path for `pgdata` to the path that the postgres user has access to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org