You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/31 12:57:31 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3260: NuttX: update licenses to Apache
jerpelea opened a new pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260
## Summary
Update the license for several contributors that have submitted ICLA or SGA
## Impact
NONE
## Testing
NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811999371
@Ouss4 looks like our mac checks fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811779349
Ready for merge
The remaining errors are Mixed Case errors
I think that we should add as exceptions the following:
for data
*Gb*, *Mb*, *Kb*
time
*us, *ms
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811047413
please do not merge yet!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811073846
We can leave it open but marked as draft, which hides the "merge" button.
Also, note that if you intend to keep working on this, please cancel the CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea removed a comment on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea removed a comment on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811112044
I need the CI run to get the list of nxstyle offender
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811779349
ready for merge
The remaining errors are Mixed Case errors
I think that we should add as exceptions the following:
for data
*Gb*, *Mb*, *Kb*
time
*us, *ms
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-812018944
Let's just merge it. This PR already went through the tests before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811049062
> please do not merge yet!
@jerpelea Do you want to set this to a draft until it is ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811051020
NO please leave it open (it should be ready to merge tomorrow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-812015467
It seems to be an "internal error" with GitHub Actions. I would try rebasing and repushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #3260: NuttX: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #3260:
URL: https://github.com/apache/incubator-nuttx/pull/3260#issuecomment-811999371
@Ouss4 looks like our mac checks fail but I cant see any reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org