You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/08/09 21:38:14 UTC
[GitHub] [spark] hvanhovell opened a new pull request, #42419: [SPARK-44747][CONNECT] Add missing SparkSession.Builder methods.
hvanhovell opened a new pull request, #42419:
URL: https://github.com/apache/spark/pull/42419
### What changes were proposed in this pull request?
This PR adds a couple methods to SparkSession.Builder:
- `conf` - this group of methods allows you to set runtime configurations on the Spark Connect Session.
- `master` - this is a no-op, it is only added for compatibility.
- `appName` - this is a no-op, it is only added for compatibility.
- `enableHiveSupport ` - this is a no-op, it is only added for compatibility.
### Why are the changes needed?
We want to maximize compatiblity with the existing API in sql/core.
### Does this PR introduce _any_ user-facing change?
Yes. It adds a couple of builder methods.
### How was this patch tested?
Add tests to `SparkSessionSuite` and `SparkSessionE2ESuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42419: [SPARK-44747][CONNECT] Add missing SparkSession.Builder methods.
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42419: [SPARK-44747][CONNECT] Add missing SparkSession.Builder methods.
URL: https://github.com/apache/spark/pull/42419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42419: [SPARK-44747][CONNECT] Add missing SparkSession.Builder methods.
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42419:
URL: https://github.com/apache/spark/pull/42419#issuecomment-1672499298
create https://issues.apache.org/jira/browse/SPARK-44750?filter=-2 to track the python side, will work with @michaelzhang-db on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42419: [SPARK-44747][CONNECT] Add missing SparkSession.Builder methods.
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42419:
URL: https://github.com/apache/spark/pull/42419#issuecomment-1672372658
Merged to master and branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #42419: [SPARK-44747][CONNECT] Add missing SparkSession.Builder methods.
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #42419:
URL: https://github.com/apache/spark/pull/42419#issuecomment-1672329384
@HyukjinKwon PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org