You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/20 13:22:04 UTC
[GitHub] [incubator-doris] xiaokang opened a new pull request, #9714: Fix lz4f optimization thread unsafe
xiaokang opened a new pull request, #9714:
URL: https://github.com/apache/incubator-doris/pull/9714
# Proposed changes
Issue Number: close #9706 , which was introduced by https://github.com/apache/incubator-doris/pull/9566
Make reusing compress/decompress context object thread safe by using thread_local.
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xiaokang closed pull request #9714: Fix lz4f optimization thread unsafe
Posted by GitBox <gi...@apache.org>.
xiaokang closed pull request #9714: Fix lz4f optimization thread unsafe
URL: https://github.com/apache/incubator-doris/pull/9714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #9714: Fix lz4f optimization thread unsafe
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #9714:
URL: https://github.com/apache/incubator-doris/pull/9714#issuecomment-1135296561
> The thread_local approach is learned from #7911 by @xinyiZzz . It will be very appreciated if you have a look and check whether the usage of thread_local in this pr is right, @xinyiZzz .
Sorry I just saw it, I see you have submitted a better solution to replace this pr.
There is no problem with using thread_local, but I suggest adding thread local variables to the `ThreadContext` class. in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xiaokang commented on pull request #9714: Fix lz4f optimization thread unsafe
Posted by GitBox <gi...@apache.org>.
xiaokang commented on PR #9714:
URL: https://github.com/apache/incubator-doris/pull/9714#issuecomment-1132914792
The thread_local approach is learned from https://github.com/apache/incubator-doris/pull/7911 by @xinyiZzz . It will be very appreciated if you have a look and check whether the usage of thread_local in this pr is right, @xinyiZzz .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xiaokang commented on pull request #9714: Fix lz4f optimization thread unsafe
Posted by GitBox <gi...@apache.org>.
xiaokang commented on PR #9714:
URL: https://github.com/apache/incubator-doris/pull/9714#issuecomment-1135320964
@xinyiZzz , thank you for your suggestion and it's valuable. Yes, a better solution #9741, so this one will be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org