You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Almot77 (via GitHub)" <gi...@apache.org> on 2024/05/23 05:50:27 UTC

[PR] Defined instance_name [skywalking-php]

Almot77 opened a new pull request, #111:
URL: https://github.com/apache/skywalking-php/pull/111

   New feature - you can set instance_name.
   For enable - add to skywalking_agent.ini config:
   
   ```
   skywalking_agent.instance_name = myservername
   ```
   
   You can use ${HOSTNAME} if you want to pass host env to php-fpm. Please, refer example 1: 
   https://www.php.net/manual/en/install.fpm.configuration.php


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Defined instance_name [skywalking-php]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #111:
URL: https://github.com/apache/skywalking-php/pull/111#discussion_r1611053733


##########
docs/en/configuration/ini-settings.md:
##########
@@ -2,25 +2,27 @@
 
 This is the configuration list supported in `php.ini`.
 
-| Configuration Item                               | Description                                                                                                                           | Default Value             |
-| ------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------- | ------------------------- |
-| skywalking_agent.enable                          | Enable skywalking_agent extension or not.                                                                                             | Off                       |
-| skywalking_agent.log_file                        | Log file path.                                                                                                                        | /tmp/skywalking-agent.log |
-| skywalking_agent.log_level                       | Log level: one of `OFF`, `TRACE`, `DEBUG`, `INFO`, `WARN`, `ERROR`.                                                                   | INFO                      |
-| skywalking_agent.runtime_dir                     | Skywalking agent runtime directory.                                                                                                   | /tmp/skywalking-agent     |
-| skywalking_agent.server_addr                     | Address of skywalking oap server. Only available when `reporter_type` is `grpc`.                                                      | 127.0.0.1:11800           |
-| skywalking_agent.service_name                    | Application service name.                                                                                                             | hello-skywalking          |
-| skywalking_agent.skywalking_version              | Skywalking version, 8 or 9.                                                                                                           | 8                         |
-| skywalking_agent.authentication                  | Skywalking authentication token, let it empty if the backend isn't enabled. Only available when `reporter_type` is `grpc`.            |                           |
-| skywalking_agent.worker_threads                  | Skywalking worker threads, 0 will auto set as the cpu core size.                                                                      | 0                         |
-| skywalking_agent.enable_tls                      | Wether to enable tls for gPRC, default is false. Only available when `reporter_type` is `grpc`.                                       | Off                       |
-| skywalking_agent.ssl_trusted_ca_path             | The gRPC SSL trusted ca file. Only available when `reporter_type` is `grpc`.                                                          |                           |
-| skywalking_agent.ssl_key_path                    | The private key file. Enable mTLS when `ssl_key_path` and `ssl_cert_chain_path` exist. Only available when `reporter_type` is `grpc`. |                           |
-| skywalking_agent.ssl_cert_chain_path             | The certificate file. Enable mTLS when `ssl_key_path` and `ssl_cert_chain_path` exist. Only available when `reporter_type` is `grpc`. |                           |
-| skywalking_agent.heartbeat_period                | Agent heartbeat report period. Unit, second.                                                                                          | 30                        |
-| skywalking_agent.properties_report_period_factor | The agent sends the instance properties to the backend every heartbeat_period * properties_report_period_factor seconds.              | 10                        |
-| skywalking_agent.enable_zend_observer            | Whether to use `zend observer` instead of `zend_execute_ex` to hook the functions, this feature is only available for PHP8+.          | Off                       |
-| skywalking_agent.reporter_type                   | Reporter type, optional values are `grpc` and `kafka`.                                                                                | grpc                      |
-| skywalking_agent.kafka_bootstrap_servers         | A list of host/port pairs to use for connect to the Kafka cluster. Only available when `reporter_type` is `kafka`.                    |                           |
-| skywalking_agent.kafka_producer_config           | Configure Kafka Producer configuration in JSON format `{"key": "value}`. Only available when `reporter_type` is `kafka`.              | {}                        |
-| skywalking_agent.inject_context                  | Whether to enable automatic injection of skywalking context variables (such as `SW_TRACE_ID`). For `php-fpm` mode, it will be injected into the `$_SERVER` variable. For `swoole` mode, it will be injected into the `$request->server` variable.              | Off                    |
+| Configuration Item                               | Description                                                                                                                                                                                                                                       | Default Value             |
+| ------------------------------------------------ |---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| ------------------------- |
+| skywalking_agent.enable                          | Enable skywalking_agent extension or not.                                                                                                                                                                                                         | Off                       |
+| skywalking_agent.log_file                        | Log file path.                                                                                                                                                                                                                                    | /tmp/skywalking-agent.log |
+| skywalking_agent.log_level                       | Log level: one of `OFF`, `TRACE`, `DEBUG`, `INFO`, `WARN`, `ERROR`.                                                                                                                                                                               | INFO                      |
+| skywalking_agent.runtime_dir                     | Skywalking agent runtime directory.                                                                                                                                                                                                               | /tmp/skywalking-agent     |
+| skywalking_agent.server_addr                     | Address of skywalking oap server. Only available when `reporter_type` is `grpc`.                                                                                                                                                                  | 127.0.0.1:11800           |
+| skywalking_agent.service_name                    | Application service name.                                                                                                                                                                                                                         | hello-skywalking          |
+| skywalking_agent.skywalking_version              | Skywalking version, 8 or 9.                                                                                                                                                                                                                       | 8                         |
+| skywalking_agent.authentication                  | Skywalking authentication token, let it empty if the backend isn't enabled. Only available when `reporter_type` is `grpc`.                                                                                                                        |                           |
+| skywalking_agent.worker_threads                  | Skywalking worker threads, 0 will auto set as the cpu core size.                                                                                                                                                                                  | 0                         |
+| skywalking_agent.enable_tls                      | Wether to enable tls for gPRC, default is false. Only available when `reporter_type` is `grpc`.                                                                                                                                                   | Off                       |
+| skywalking_agent.ssl_trusted_ca_path             | The gRPC SSL trusted ca file. Only available when `reporter_type` is `grpc`.                                                                                                                                                                      |                           |
+| skywalking_agent.ssl_key_path                    | The private key file. Enable mTLS when `ssl_key_path` and `ssl_cert_chain_path` exist. Only available when `reporter_type` is `grpc`.                                                                                                             |                           |
+| skywalking_agent.ssl_cert_chain_path             | The certificate file. Enable mTLS when `ssl_key_path` and `ssl_cert_chain_path` exist. Only available when `reporter_type` is `grpc`.                                                                                                             |                           |
+| skywalking_agent.heartbeat_period                | Agent heartbeat report period. Unit, second.                                                                                                                                                                                                      | 30                        |
+| skywalking_agent.properties_report_period_factor | The agent sends the instance properties to the backend every heartbeat_period * properties_report_period_factor seconds.                                                                                                                          | 10                        |
+| skywalking_agent.enable_zend_observer            | Whether to use `zend observer` instead of `zend_execute_ex` to hook the functions, this feature is only available for PHP8+.                                                                                                                      | Off                       |
+| skywalking_agent.reporter_type                   | Reporter type, optional values are `grpc` and `kafka`.                                                                                                                                                                                            | grpc                      |
+| skywalking_agent.kafka_bootstrap_servers         | A list of host/port pairs to use for connect to the Kafka cluster. Only available when `reporter_type` is `kafka`.                                                                                                                                |                           |
+| skywalking_agent.kafka_producer_config           | Configure Kafka Producer configuration in JSON format `{"key": "value}`. Only available when `reporter_type` is `kafka`.                                                                                                                          | {}                        |
+| skywalking_agent.inject_context                  | Whether to enable automatic injection of skywalking context variables (such as `SW_TRACE_ID`). For `php-fpm` mode, it will be injected into the `$_SERVER` variable. For `swoole` mode, it will be injected into the `$request->server` variable. | Off                    |
+| skywalking_agent.instance_name                   | Instance name. You can set ${HOSTNAME}, refer example #1: https://www.php.net/manual/en/install.fpm.configuration.php                                                                                                                             |                     |

Review Comment:
   ```suggestion
   | skywalking_agent.instance_name                   | Instance name. You can set ${HOSTNAME}, refer to [Example #1]( https://www.php.net/manual/en/install.fpm.configuration.php)                                                                                                                           |                     |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Defined instance_name [skywalking-php]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #111:
URL: https://github.com/apache/skywalking-php/pull/111#issuecomment-2126306894

   You need to fix CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Defined instance_name [skywalking-php]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #111:
URL: https://github.com/apache/skywalking-php/pull/111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org