You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/06/16 12:59:25 UTC

[GitHub] [incubator-druid] xueyumusic commented on issue #7904: SQL planning slow with huge IN filters

xueyumusic commented on issue #7904: SQL planning slow with huge IN filters
URL: https://github.com/apache/incubator-druid/issues/7904#issuecomment-502449953
 
 
   Calcite has default value of [DEFAULT_IN_SUB_QUERY_THRESHOLD ](https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L227) as 20. If length of values of in clause exceeds this config calcite will not convert `in` to `or` and convert in to a semi join of table.
   However druid set this config as [MAX_VALUE](https://github.com/apache/incubator-druid/blob/master/sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerFactory.java#L115) in PlannerFactory . If there is no special purpose of setting it as MAX_VALUE, maybe we could try using default value and see whether still has this performance problem. What do you think? @gianm 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org