[GitHub] williaster commented on a change in pull request #5186: Implement a React-based table editor

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5186: Implement a React-based table editor
URL: https://github.com/apache/incubator-superset/pull/5186#discussion_r208047336
 
 

 ##########
 File path: superset/assets/src/CRUD/CollectionTable.jsx
 ##########
 @@ -0,0 +1,220 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import shortid from 'shortid';
+
+import Button from '../components/Button';
+import Fieldset from './Fieldset';
+import { recurseReactClone } from './utils';
+import './styles.css';
+
+const propTypes = {
+  collection: PropTypes.array,
 
 Review comment:
   also all non-required props should have a default, I don't think that's true here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org