You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stricklandrbls (via GitHub)" <gi...@apache.org> on 2023/04/06 13:58:37 UTC
[GitHub] [daffodil-vscode] stricklandrbls opened a new pull request, #575: Reworded Replace err msg
stricklandrbls opened a new pull request, #575:
URL: https://github.com/apache/daffodil-vscode/pull/575
- If the user has viewport data selected and enters text into the replace field, the err response is more clear.
Closes #574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on pull request #575: Reworded Replace err msg
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on PR #575:
URL: https://github.com/apache/daffodil-vscode/pull/575#issuecomment-1499460613
@Shanedell The latest commit has the issue revision implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #575: Reworded Replace err msg and ergonomic enhancements
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #575:
URL: https://github.com/apache/daffodil-vscode/pull/575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #575: Reworded Replace err msg
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on code in PR #575:
URL: https://github.com/apache/daffodil-vscode/pull/575#discussion_r1159863332
##########
src/svelte/src/stores/index.ts:
##########
@@ -241,7 +241,7 @@ export const replaceable = derived(
}
if ($selectionActive) {
replaceErrMsg.update(() => {
- return 'Cannot replace with selected data'
+ return 'Cannot replace while viewport data selected'
Review Comment:
Might as well haha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on pull request #575: Reworded Replace err msg
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on PR #575:
URL: https://github.com/apache/daffodil-vscode/pull/575#issuecomment-1499266869
@Shanedell Don't approve and merge this yet. I've added a revision to the Issue as it is related to the `Replace` field:
### Issue #574 Revision
> ### Revision Addition
>
>The input fields for both Search and Replace should appear to the right of their labels. Some screen resolution have been marking this <fieldset> as overflow and adding a scrollbar. Moving the input fields will trim the vertical space alloted and stop this overflow scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #575: Reworded Replace err msg
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #575:
URL: https://github.com/apache/daffodil-vscode/pull/575#discussion_r1159851836
##########
src/svelte/src/stores/index.ts:
##########
@@ -241,7 +241,7 @@ export const replaceable = derived(
}
if ($selectionActive) {
replaceErrMsg.update(() => {
- return 'Cannot replace with selected data'
+ return 'Cannot replace while viewport data selected'
Review Comment:
might as well add `is` selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on pull request #575: Reworded Replace err msg
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on PR #575:
URL: https://github.com/apache/daffodil-vscode/pull/575#issuecomment-1499495200
@Shanedell Revision edits have been implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org