[GitHub] HyukjinKwon commented on issue #23184: [SPARK-26227][R] from_[csv|json] should accept schema_of_[csv|json] in R API

[GitBox <gi...@apache.org>]

HyukjinKwon commented on issue #23184: [SPARK-26227][R] from_[csv|json] should accept schema_of_[csv|json] in R API
URL: https://github.com/apache/spark/pull/23184#issuecomment-450704499
 
 
   Yea, Scala side change is already made about `from_[csv|json](schema_of_[csv|json]())`.
   
   However, about https://github.com/apache/spark/pull/23184#discussion_r244296221 and https://github.com/apache/spark/pull/23184#discussion_r244295745, yea, the signatures are not consistent .. 
   
   One possibility that was considered before is to match it to only use `Column` across API (vaguely talked with Wenchen in .. somewhere of a PR before), but it's too breaking change..
   There's concern that `functions.scala` file is getting too long so it's been avoided to add overriden versions of such APIs.
   
   I think we should handle this problem for whole APIs later ..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org