You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/07/01 22:01:52 UTC

[GitHub] [arrow] kou commented on a diff in pull request #36422: GH-36421: [Java] Enable Support for reading JSON Datasets

kou commented on code in PR #36422:
URL: https://github.com/apache/arrow/pull/36422#discussion_r1248989539


##########
java/dataset/src/test/java/org/apache/arrow/dataset/CsvJsonWriteSupport.java:
##########
@@ -24,17 +24,18 @@
 import java.net.URISyntaxException;
 import java.util.Random;
 
-public class CsvWriteSupport {
+public class CsvJsonWriteSupport {

Review Comment:
   How about using `TextBasedWriteSupport` or something?
   If we use this style, we may need to add more formats to class name such as `CsvJsonXXXYYYWriteSupport` in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org