[GitHub] [iceberg] rdblue commented on a diff in pull request #5505: API: Deprecate generic Counter and replace with simpler Counter API

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5505:
URL: https://github.com/apache/iceberg/pull/5505#discussion_r943828940


##########
api/src/main/java/org/apache/iceberg/metrics/Counter.java:
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.metrics;
+
+import org.apache.iceberg.metrics.MetricsContext.Unit;
+
+/** Generalized Counter interface for creating telemetry-related instances when counting events. */
+public interface Counter {
+
+  /** Increment the counter by 1. */
+  void increment();
+
+  /**
+   * Increment the counter by the provided amount.
+   *
+   * @param amount to be incremented.
+   */
+  void increment(long amount);
+
+  /**
+   * Reports the current count.
+   *
+   * @return The current count.
+   */
+  long value();
+
+  /**
+   * The unit of the counter.
+   *
+   * @return The unit of the counter.
+   */
+  default Unit unit() {
+    return Unit.COUNT;
+  }
+
+  /**
+   * The name of the counter.
+   *
+   * @return The name of the counter.
+   */
+  default String name() {

Review Comment:
   If this is a new API, I think we can require `name`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org