You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/10/23 21:24:45 UTC
Review Request 39609: Upgrade: upgrade endpoint should expose
Upgrade/upgrade_type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39609/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-13552
https://issues.apache.org/jira/browse/AMBARI-13552
Repository: ambari
Description
-------
The Upgrade/type field is already used as a linked field from the Request object, so expose the upgrade type (ROLLING/EXPRESS (aka NON_ROLLING)) as Upgrade/upgrade_type
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 044c707
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bb78ca2
Diff: https://reviews.apache.org/r/39609/diff/
Testing
-------
Manual; automated pending
Thanks,
Nate Cole
Re: Review Request 39609: Upgrade: upgrade endpoint should expose
Upgrade/upgrade_type
Posted by Nate Cole <nc...@hortonworks.com>.
> On Oct. 23, 2015, 3:27 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 212
> > <https://reviews.apache.org/r/39609/diff/1/?file=1105280#file1105280line212>
> >
> > Just as an FYI, you may have problems cherry picking this injection changes to branch-2.1 - it might still be used there.
Great point - i'll see what my diff thinks. If it bitches I'll revert this particular change.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39609/#review103833
-----------------------------------------------------------
On Oct. 23, 2015, 3:24 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39609/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 3:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-13552
> https://issues.apache.org/jira/browse/AMBARI-13552
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Upgrade/type field is already used as a linked field from the Request object, so expose the upgrade type (ROLLING/EXPRESS (aka NON_ROLLING)) as Upgrade/upgrade_type
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 044c707
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bb78ca2
>
> Diff: https://reviews.apache.org/r/39609/diff/
>
>
> Testing
> -------
>
> Manual; automated pending
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 39609: Upgrade: upgrade endpoint should expose
Upgrade/upgrade_type
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39609/#review103833
-----------------------------------------------------------
Ship it!
Ship It!
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/39609/#comment161934>
Just as an FYI, you may have problems cherry picking this injection changes to branch-2.1 - it might still be used there.
- Jonathan Hurley
On Oct. 23, 2015, 3:24 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39609/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 3:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-13552
> https://issues.apache.org/jira/browse/AMBARI-13552
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Upgrade/type field is already used as a linked field from the Request object, so expose the upgrade type (ROLLING/EXPRESS (aka NON_ROLLING)) as Upgrade/upgrade_type
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 044c707
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bb78ca2
>
> Diff: https://reviews.apache.org/r/39609/diff/
>
>
> Testing
> -------
>
> Manual; automated pending
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 39609: Upgrade: upgrade endpoint should expose
Upgrade/upgrade_type
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39609/#review103832
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 23, 2015, 7:24 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39609/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 7:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-13552
> https://issues.apache.org/jira/browse/AMBARI-13552
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Upgrade/type field is already used as a linked field from the Request object, so expose the upgrade type (ROLLING/EXPRESS (aka NON_ROLLING)) as Upgrade/upgrade_type
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 044c707
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java bb78ca2
>
> Diff: https://reviews.apache.org/r/39609/diff/
>
>
> Testing
> -------
>
> Manual; automated pending
>
>
> Thanks,
>
> Nate Cole
>
>