You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Daniel John Debrunner (JIRA)" <de...@db.apache.org> on 2006/08/03 07:25:13 UTC
[jira] Created: (DERBY-1638) JUnit TestConfiguration class uses
engine code to determine JDBC level.
JUnit TestConfiguration class uses engine code to determine JDBC level.
-----------------------------------------------------------------------
Key: DERBY-1638
URL: http://issues.apache.org/jira/browse/DERBY-1638
Project: Derby
Issue Type: Improvement
Components: Test
Reporter: Daniel John Debrunner
Assigned To: Daniel John Debrunner
Priority: Minor
TestConfiguration uses the org.apache.derby.iapi.services.info.JVMInfo to determine if JDBC 4 is supported. Ideally test code should not be calling engine private api code.
Suggest two changes:
1) Determine JDBC level support from ability to load classes:
E.g. JDBC2 - java.sql.Driver
JDBC3 - java.sql.Driver AND java.sql.ParameterMetaData
JDBC4 - java.sql.Driver AND java.sql.SQLXML
JSR169 - java.sql.ParameterMetaData AND NOT java.sql.Driver
2) Move the supportsJDBC4() method from TestConfiguraiton to JDBC, since if the VM supports JDBC4 or not is
not an attribute of a test configuration (and add other supportsJDBCX methods).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1638) JUnit TestConfiguration class uses
engine code to determine JDBC level.
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1638?page=all ]
Daniel John Debrunner updated DERBY-1638:
-----------------------------------------
Attachment: derby1638_diff.txt
Patch that makes described changes, adding these methods
supportsJDBC2()
supportsJDBC3()
supportsJSR169()
Might consider changing the methods to be *is* instead of *supports* (e.g isJDBC4()) since they are describing
that the environment is JDBC 4, not what any client may support.
Then new (yet to be added) methods called supportsJDBC4() might make sense in TestConfiguraiton or maybe JDBCClient to indicate that the client under test is running at a different level, e.g. for the ability to support testing the old 10.1 driver in jdk16 against the new 10.2 server.
> JUnit TestConfiguration class uses engine code to determine JDBC level.
> -----------------------------------------------------------------------
>
> Key: DERBY-1638
> URL: http://issues.apache.org/jira/browse/DERBY-1638
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Daniel John Debrunner
> Assigned To: Daniel John Debrunner
> Priority: Minor
> Attachments: derby1638_diff.txt
>
>
> TestConfiguration uses the org.apache.derby.iapi.services.info.JVMInfo to determine if JDBC 4 is supported. Ideally test code should not be calling engine private api code.
> Suggest two changes:
> 1) Determine JDBC level support from ability to load classes:
> E.g. JDBC2 - java.sql.Driver
> JDBC3 - java.sql.Driver AND java.sql.ParameterMetaData
> JDBC4 - java.sql.Driver AND java.sql.SQLXML
> JSR169 - java.sql.ParameterMetaData AND NOT java.sql.Driver
> 2) Move the supportsJDBC4() method from TestConfiguraiton to JDBC, since if the VM supports JDBC4 or not is
> not an attribute of a test configuration (and add other supportsJDBCX methods).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1638) JUnit TestConfiguration class uses
engine code to determine JDBC level.
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1638?page=all ]
Daniel John Debrunner updated DERBY-1638:
-----------------------------------------
Derby Info: [Patch Available]
> JUnit TestConfiguration class uses engine code to determine JDBC level.
> -----------------------------------------------------------------------
>
> Key: DERBY-1638
> URL: http://issues.apache.org/jira/browse/DERBY-1638
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Daniel John Debrunner
> Assigned To: Daniel John Debrunner
> Priority: Minor
> Attachments: derby1638_diff.txt
>
>
> TestConfiguration uses the org.apache.derby.iapi.services.info.JVMInfo to determine if JDBC 4 is supported. Ideally test code should not be calling engine private api code.
> Suggest two changes:
> 1) Determine JDBC level support from ability to load classes:
> E.g. JDBC2 - java.sql.Driver
> JDBC3 - java.sql.Driver AND java.sql.ParameterMetaData
> JDBC4 - java.sql.Driver AND java.sql.SQLXML
> JSR169 - java.sql.ParameterMetaData AND NOT java.sql.Driver
> 2) Move the supportsJDBC4() method from TestConfiguraiton to JDBC, since if the VM supports JDBC4 or not is
> not an attribute of a test configuration (and add other supportsJDBCX methods).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1638) JUnit TestConfiguration class uses
engine code to determine JDBC level.
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1638?page=all ]
Daniel John Debrunner updated DERBY-1638:
-----------------------------------------
Derby Info: (was: [Patch Available])
Made similar changes to patch. Change from patch is to name the methods vmSupportsJDBC4 etc. to clearly define it's the level of support provided by the virtual machine (and not the client for example).
Committed revision 429154.
> JUnit TestConfiguration class uses engine code to determine JDBC level.
> -----------------------------------------------------------------------
>
> Key: DERBY-1638
> URL: http://issues.apache.org/jira/browse/DERBY-1638
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Daniel John Debrunner
> Assigned To: Daniel John Debrunner
> Priority: Minor
> Attachments: derby1638_diff.txt
>
>
> TestConfiguration uses the org.apache.derby.iapi.services.info.JVMInfo to determine if JDBC 4 is supported. Ideally test code should not be calling engine private api code.
> Suggest two changes:
> 1) Determine JDBC level support from ability to load classes:
> E.g. JDBC2 - java.sql.Driver
> JDBC3 - java.sql.Driver AND java.sql.ParameterMetaData
> JDBC4 - java.sql.Driver AND java.sql.SQLXML
> JSR169 - java.sql.ParameterMetaData AND NOT java.sql.Driver
> 2) Move the supportsJDBC4() method from TestConfiguraiton to JDBC, since if the VM supports JDBC4 or not is
> not an attribute of a test configuration (and add other supportsJDBCX methods).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-1638) JUnit TestConfiguration class uses
engine code to determine JDBC level.
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1638?page=all ]
Daniel John Debrunner closed DERBY-1638.
----------------------------------------
Fix Version/s: 10.2.0.0
Resolution: Fixed
> JUnit TestConfiguration class uses engine code to determine JDBC level.
> -----------------------------------------------------------------------
>
> Key: DERBY-1638
> URL: http://issues.apache.org/jira/browse/DERBY-1638
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Daniel John Debrunner
> Assigned To: Daniel John Debrunner
> Priority: Minor
> Fix For: 10.2.0.0
>
> Attachments: derby1638_diff.txt
>
>
> TestConfiguration uses the org.apache.derby.iapi.services.info.JVMInfo to determine if JDBC 4 is supported. Ideally test code should not be calling engine private api code.
> Suggest two changes:
> 1) Determine JDBC level support from ability to load classes:
> E.g. JDBC2 - java.sql.Driver
> JDBC3 - java.sql.Driver AND java.sql.ParameterMetaData
> JDBC4 - java.sql.Driver AND java.sql.SQLXML
> JSR169 - java.sql.ParameterMetaData AND NOT java.sql.Driver
> 2) Move the supportsJDBC4() method from TestConfiguraiton to JDBC, since if the VM supports JDBC4 or not is
> not an attribute of a test configuration (and add other supportsJDBCX methods).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira