[jira] [Commented] (CB-5468) improve config.xml encoding handling

["Josh Soref (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835034#comment-13835034 ] 

Josh Soref commented on CB-5468:
--------------------------------

Pull request:
* https://github.com/apache/cordova-blackberry/pull/127 - [~jkeshavarzi] please review

Unsubmitted changes:
* https://github.com/blackberry/cordova-cli/compare/cb_5468?expand=1
* https://github.com/blackberry/cordova-plugman/compare/cb_5468?expand=1

> improve config.xml encoding handling
> ------------------------------------
>
>                 Key: CB-5468
>                 URL: https://issues.apache.org/jira/browse/CB-5468
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry, CLI, Plugman
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>
> If you have a config.xml w/o a BOM in UTF-8 and try to use cordova build on BlackBerry, you'll get an error.
> That logic is here:
> https://github.com/apache/cordova-blackberry/blob/master/blackberry10/bin/templates/project/cordova/lib/packager-utils.js#L143
> cordova cli on the other hand seems to only handle UTF-8 (and not UCS2/UTF-16).
> That logic is here:
> https://github.com/apache/cordova-cli/blob/master/src/xml-helpers.js#L111
> The specification for config.xml is here:
> http://www.w3.org/TR/widgets/#algorithm-to-process-a-configuration-document
> Let doc be the result of loading the widget config doc as a [DOMCore] Document using an [XML] parser that is both [XMLNS]-aware and xml:lang aware.
> [XML] defers to:
> http://www.w3.org/TR/2008/REC-xml-20081126/#charsets
> which says:
> The mechanism for encoding character code points into bit patterns may vary from entity to entity. All XML processors must accept the UTF-8 and UTF-16 encodings of Unicode [Unicode].



--
This message was sent by Atlassian JIRA
(v6.1#6144)