Re: JSF.js TS commit ready in myfaces 4.0

[Werner Punz <we...@gmail.com>]

Hi just some updates, I have check the integration tests, they do not work
atm infrastructurewise, however
they should work theoretically once the test infrastructure is debugged
(aquilian seems to have some issues atm)
https://issues.apache.org/jira/browse/MYFACES-4473

The thing is, I just ran a test against our node based unit tests and they
seem to run fine. The maven frontend plugin seems to terminate correctly
on failures in unit tests:
here is an example:

it('initializable', () => {
    const lang = Lang;
    expect(false).to.be.true('must be true');
    expect(lang).to.exist;
});


As result i get from the maven build:
NFO]   135 passing (2s)
[INFO]   1 failing
[INFO]
[INFO]   1) Lang tests
[INFO]        initializable:
[INFO]
[INFO]       AssertionError: expected false to be true
[INFO]       + expected - actual

INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time:  30.855 s
[INFO] Finished at: 2022-10-05T15:16:47+02:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
com.github.eirslett:frontend-maven-plugin:1.12.1:npm (npm run test) on
project myfaces-api: Failed to run task: 'npm run test' failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 1
(Exit value: 1) -> [Help 1]

So I am positively surprised.

The aquilian tests for ajax basically do not really trigger our
implementation, they return a fake response from a servlet but cause a ton
of java code to produce the response xml.
It is easy just to proxy the response and let everything run on the client.

Either way, Just wanted to open a discussion here.


Werner




Am Fr., 30. Sept. 2022 um 08:08 Uhr schrieb Werner Punz <
werner.punz@gmail.com>:

> So next steps: While you guys now can review the code and test it.
>
> I will overhaul my internal integration tests to reduce the remnants of
> the old framework code and make the code better.
>
> After that I will tackle the internal myfaces js integration tests which
> atm are defunct.
> For now not having integration tests are safe, because we test with Tobago
> and, I now have 136 unit tests in place in conjunction with my own publicly
> github hosted integration tests, but this should not be a permanent
> solution.
>
> Werner
>
>
> Am Do., 29. Sept. 2022 um 14:00 Uhr schrieb Werner Punz <
> werner.punz@gmail.com>:
>
>> Thanks, pull request is now in place,
>> https://github.com/apache/myfaces/pull/325
>> please review and test!
>>
>>
>> Werner
>>
>>
>> Am Do., 29. Sept. 2022 um 13:33 Uhr schrieb Werner Punz <
>> werner.punz@gmail.com>:
>>
>>> Yes thats even better.
>>> I will issue a pull request, I think thats the best idea for now.
>>> I will go this route then.
>>>
>>> Werner
>>>
>>>
>>> Am Do., 29. Sept. 2022 um 13:31 Uhr schrieb Melloware <
>>> mellowaredev@gmail.com>:
>>>
>>>> Yep why not just submit a PR in a feature branch so we can code review
>>>> it on GitHub like a normal PR?
>>>>
>>>> On 9/29/2022 5:57 AM, Werner Punz wrote:
>>>> > Hi I wrote it before, but in the never ending list of replies it went
>>>> > under.
>>>> > I am basically commit-ready for the updated code. I will skip the
>>>> work
>>>> > on the integration tests now
>>>> > given they do not work atm anyway due to dependency issues and they
>>>> > are based on my working github ones anyway.
>>>> > (I will revisit this part next week)
>>>> >
>>>> > However, given that I did a ton of changes in the resource loaders,
>>>> > dropped literally all old files, changed the pom quite a bit and
>>>> > introduced
>>>> > the maven client plugin which triggers node, instead of running
>>>> > straight maven plugins, I would love to have a proper review and
>>>> > testing from the community, before merging.
>>>> > So my proposal is, I will push the changes for now into a feature
>>>> > branch, if possible, so that anyone can test the build and the new
>>>> > codebase who wants to, and after a period of feedback time when
>>>> > everyone is happy we merge it into the 4.0 release candidates.
>>>> >
>>>> >
>>>> > Any comments on that?
>>>> >
>>>> > Werner
>>>> >
>>>> >
>>>>
>>>
Am Fr., 30. Sept. 2022 um 08:08 Uhr schrieb Werner Punz <
werner.punz@gmail.com>:

> So next steps: While you guys now can review the code and test it.
>
> I will overhaul my internal integration tests to reduce the remnants of
> the old framework code and make the code better.
>
> After that I will tackle the internal myfaces js integration tests which
> atm are defunct.
> For now not having integration tests are safe, because we test with Tobago
> and, I now have 136 unit tests in place in conjunction with my own publicly
> github hosted integration tests, but this should not be a permanent
> solution.
>
> Werner
>
>
> Am Do., 29. Sept. 2022 um 14:00 Uhr schrieb Werner Punz <
> werner.punz@gmail.com>:
>
>> Thanks, pull request is now in place,
>> https://github.com/apache/myfaces/pull/325
>> please review and test!
>>
>>
>> Werner
>>
>>
>> Am Do., 29. Sept. 2022 um 13:33 Uhr schrieb Werner Punz <
>> werner.punz@gmail.com>:
>>
>>> Yes thats even better.
>>> I will issue a pull request, I think thats the best idea for now.
>>> I will go this route then.
>>>
>>> Werner
>>>
>>>
>>> Am Do., 29. Sept. 2022 um 13:31 Uhr schrieb Melloware <
>>> mellowaredev@gmail.com>:
>>>
>>>> Yep why not just submit a PR in a feature branch so we can code review
>>>> it on GitHub like a normal PR?
>>>>
>>>> On 9/29/2022 5:57 AM, Werner Punz wrote:
>>>> > Hi I wrote it before, but in the never ending list of replies it went
>>>> > under.
>>>> > I am basically commit-ready for the updated code. I will skip the
>>>> work
>>>> > on the integration tests now
>>>> > given they do not work atm anyway due to dependency issues and they
>>>> > are based on my working github ones anyway.
>>>> > (I will revisit this part next week)
>>>> >
>>>> > However, given that I did a ton of changes in the resource loaders,
>>>> > dropped literally all old files, changed the pom quite a bit and
>>>> > introduced
>>>> > the maven client plugin which triggers node, instead of running
>>>> > straight maven plugins, I would love to have a proper review and
>>>> > testing from the community, before merging.
>>>> > So my proposal is, I will push the changes for now into a feature
>>>> > branch, if possible, so that anyone can test the build and the new
>>>> > codebase who wants to, and after a period of feedback time when
>>>> > everyone is happy we merge it into the 4.0 release candidates.
>>>> >
>>>> >
>>>> > Any comments on that?
>>>> >
>>>> > Werner
>>>> >
>>>> >
>>>>
>>>

Re: JSF.js TS commit ready in myfaces 4.0

[Melloware <me...@gmail.com>]

I found an interesting one I wanted the teams thoughts on.  I am using 
MyFaces with Wildfly and I see this warning message....


INFO  [org.jboss.weld.Event] (MSC service thread 1-5) WELD-000411: 
Observer method [BackedAnnotatedMethod] 
org.apache.myfaces.config.annotation.CdiAnnotationProviderExtension.processAnnotatedType(@Observes 
ProcessAnnotatedType<T>) receives events for all annotated types. 
Consider restricting events using @WithAnnotations or a generic type 
with bounds.


It basically is saying we are catching everything and not specific 
annotations?