You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2018/12/14 04:07:33 UTC

[GitHub] [incubator-dubbo] codecov-io commented on issue #2963: fix potential concurrency issue in a simpler way for ActiveLimitFilter and ExecuteLimitFilter

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2963?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@2fad342`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `87.5%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2963/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2963?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master    #2963   +/-   ##
=========================================
  Coverage          ?   63.99%           
=========================================
  Files             ?      584           
  Lines             ?    26045           
  Branches          ?     4561           
=========================================
  Hits              ?    16667           
  Misses            ?     7202           
  Partials          ?     2176
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2963?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2963/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTdGF0dXMuamF2YQ==) | `60.67% <100%> (ø)` | |
| [...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2963/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvRXhlY3V0ZUxpbWl0RmlsdGVyLmphdmE=) | `89.47% <100%> (ø)` | |
| [...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2963/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQWN0aXZlTGltaXRGaWx0ZXIuamF2YQ==) | `88.88% <85.18%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2963?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2963?src=pr&el=footer). Last update [2fad342...50dd0c4](https://codecov.io/gh/apache/incubator-dubbo/pull/2963?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2963 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org