You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Jeff Turner <je...@apache.org> on 2003/09/15 12:35:00 UTC

XML links (Re: cvs commit: xml-forrest/src/resources/forrest-shbat forrest.build.xml)

On Sun, Sep 14, 2003 at 01:40:57PM -0000, cheche@apache.org wrote:
> cheche      2003/09/14 06:40:57
> 
>   Modified:    src/resources/forrest-shbat forrest.build.xml
>   Log:
>   Validate-site target fail if a site does not have xml link enable.
...
>   -  <target name="validate-site" depends="validation-props" >
>   +  <target name="validate-site" depends="load-project-props">
>   +    <condition property="forrest.validate.skinconf.disable-xml-link">
>   +      <and>
>   +        <istrue value="${skinconfig.disable-xml-link}"/>
>   +      </and>
>   +    </condition>
>   +    <fail if="forrest.validate.skinconf.disable-xml-link">
>   +---------------------------------------     
>   +${skinconfig.project-name} have disable-xml-link
>   +please change it on ${project.skinconf} 
>   +to validate this site.
>   +---------------------------------------     
>   +    </fail>


It looks like you have the logic backwards here.  This fails is
disable-xml-link is true, which is the default.

I have never understood why the value of disable-xml-links affects
pre-render validation.  Could you explain it to me again?  Thanks..


--Jeff

Re: XML links (Re: cvs commit: xml-forrest/src/resources/forrest-shbat forrest.build.xml)

Posted by Juan Jose Pablos <ch...@che-che.com>.
Jeff Turner wrote:
> 
> 
> Oh I see.  Validation of the generated XML.  Cool.  Maybe one day we can
> expand it to do HTML 4.0.1 validation, as that keeps breaking.
> 
> 

Yes and added to the "release things to do" There is mentions of our 
bronken liks in a few newsgroups.

I would like to get SVG and FOP validation first. There is plenty of 
HTML 4.0.1 validation tools outhere.

Cheers,
Cheche


Re: XML links (Re: cvs commit: xml-forrest/src/resources/forrest-shbat forrest.build.xml)

Posted by Jeff Turner <je...@apache.org>.
On Mon, Sep 15, 2003 at 12:43:09PM +0200, Juan Jose Pablos wrote:
> Jeff,
> 
> >> +    <condition property="forrest.validate.skinconf.disable-xml-link">
> >> +      <and>
> >> +        <istrue value="${skinconfig.disable-xml-link}"/>
> >> +      </and>
> >> +    </condition>
> >> +    <fail if="forrest.validate.skinconf.disable-xml-link">
> >> +---------------------------------------     
> >> +${skinconfig.project-name} have disable-xml-link
> >> +please change it on ${project.skinconf} 
> >> +to validate this site.
> >> +---------------------------------------     
> >> +    </fail>
> >
> >
> >
> >It looks like you have the logic backwards here.  This fails is
> >disable-xml-link is true, which is the default.
> 
> That is right. As default no-one produce xml output, but we need to 
> produce xml files in order to validate them.
> 
> >
> >I have never understood why the value of disable-xml-links affects
> >pre-render validation.  Could you explain it to me again?  Thanks..
> 
> Because it is not pre-render validation, It validates our intermediate 
> format (doc-v12).
> 
> This is to ensure that you *2document.xsl works properly.

Oh I see.  Validation of the generated XML.  Cool.  Maybe one day we can
expand it to do HTML 4.0.1 validation, as that keeps breaking.


--Jeff

> Cheers,
> Cheche
> 

Re: XML links (Re: cvs commit: xml-forrest/src/resources/forrest-shbat forrest.build.xml)

Posted by Juan Jose Pablos <ch...@che-che.com>.
Jeff,

>>  +    <condition property="forrest.validate.skinconf.disable-xml-link">
>>  +      <and>
>>  +        <istrue value="${skinconfig.disable-xml-link}"/>
>>  +      </and>
>>  +    </condition>
>>  +    <fail if="forrest.validate.skinconf.disable-xml-link">
>>  +---------------------------------------     
>>  +${skinconfig.project-name} have disable-xml-link
>>  +please change it on ${project.skinconf} 
>>  +to validate this site.
>>  +---------------------------------------     
>>  +    </fail>
> 
> 
> 
> It looks like you have the logic backwards here.  This fails is
> disable-xml-link is true, which is the default.

That is right. As default no-one produce xml output, but we need to 
produce xml files in order to validate them.

> 
> I have never understood why the value of disable-xml-links affects
> pre-render validation.  Could you explain it to me again?  Thanks..

Because it is not pre-render validation, It validates our intermediate 
format (doc-v12).

This is to ensure that you *2document.xsl works properly.

Cheers,
Cheche