[GitHub] mistercrunch closed pull request #5400: Fix the build

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5400: Fix the build
URL: https://github.com/apache/incubator-superset/pull/5400
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/requirements-dev.txt b/requirements-dev.txt
index 7f9616395e..54fe2f0681 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -4,5 +4,6 @@ mysqlclient==1.3.12
 psycopg2==2.7.4
 redis==2.10.6
 statsd==3.2.2
-tox==2.9.1
+tox==3.1.2
 console_log==0.2.10
+pylint==1.9.2
diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx
index 9f5079c40c..ecd0ba0520 100644
--- a/superset/assets/src/explore/controls.jsx
+++ b/superset/assets/src/explore/controls.jsx
@@ -208,7 +208,6 @@ export const controls = {
     multi: true,
     default: [],
     label: t('Percentage Metrics'),
-    default: [],
     validators: [],
     description: t('Metrics for which percentage of total are to be displayed'),
   },
diff --git a/tox.ini b/tox.ini
index 2b2678eae4..cfc081d00e 100644
--- a/tox.ini
+++ b/tox.ini
@@ -67,16 +67,14 @@ deps =
 
 [testenv:pylint]
 commands =
-    pylint superset
+    pylint -v -j 2 superset
 deps =
     -rrequirements.txt
     -rrequirements-dev.txt
-    pylint
 
 [tox]
 envlist =
     eslint
     flake8
     javascript
-    pylint
 skipsdist = true


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org