You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/15 00:29:44 UTC
[GitHub] [iceberg-docs] amogh-jahagirdar opened a new pull request #54: Docs: Add javadoc for 0.13.1 release
amogh-jahagirdar opened a new pull request #54:
URL: https://github.com/apache/iceberg-docs/pull/54
This change includes java docs for the 0.13.1 release. Javadocs were generated by checking out at the 0.13.1 tag in Iceberg and running ./gradlew refreshJavadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a change in pull request #54: Docs: Add javadoc for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #54:
URL: https://github.com/apache/iceberg-docs/pull/54#discussion_r807129391
##########
File path: javadoc/help-doc.html
##########
@@ -26,25 +17,20 @@
catch(err) {
}
//-->
-var pathtoroot = "./";
-var useModuleDirectories = true;
-loadScripts(document, 'script');</script>
+</script>
<noscript>
<div>JavaScript is disabled on your browser.</div>
</noscript>
-<header role="banner">
-<nav role="navigation">
-<div class="fixedNav">
<!-- ========= START OF TOP NAVBAR ======= -->
-<div class="topNav"><a id="navbar.top">
+<div class="topNav"><a name="navbar.top">
Review comment:
seems like there are some changes to HTMLs not related to the version change. Have you tested out if the UI still displays correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on pull request #54: Docs: Add javadoc for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #54:
URL: https://github.com/apache/iceberg-docs/pull/54#issuecomment-1040828555
Thanks for the work! @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] amogh-jahagirdar commented on a change in pull request #54: Docs: Add javadoc for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on a change in pull request #54:
URL: https://github.com/apache/iceberg-docs/pull/54#discussion_r807312008
##########
File path: javadoc/help-doc.html
##########
@@ -26,25 +17,20 @@
catch(err) {
}
//-->
-var pathtoroot = "./";
-var useModuleDirectories = true;
-loadScripts(document, 'script');</script>
+</script>
<noscript>
<div>JavaScript is disabled on your browser.</div>
</noscript>
-<header role="banner">
-<nav role="navigation">
-<div class="fixedNav">
<!-- ========= START OF TOP NAVBAR ======= -->
-<div class="topNav"><a id="navbar.top">
+<div class="topNav"><a name="navbar.top">
Review comment:
I opened up the index.html and clicked around to validate there were no issues. I opened up the help-doc (this page) and a few other class specific docs, and other pages and don't see any issues. Let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 merged pull request #54: Docs: Add javadoc for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #54:
URL: https://github.com/apache/iceberg-docs/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a change in pull request #54: Docs: Add javadoc for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #54:
URL: https://github.com/apache/iceberg-docs/pull/54#discussion_r807129391
##########
File path: javadoc/help-doc.html
##########
@@ -26,25 +17,20 @@
catch(err) {
}
//-->
-var pathtoroot = "./";
-var useModuleDirectories = true;
-loadScripts(document, 'script');</script>
+</script>
<noscript>
<div>JavaScript is disabled on your browser.</div>
</noscript>
-<header role="banner">
-<nav role="navigation">
-<div class="fixedNav">
<!-- ========= START OF TOP NAVBAR ======= -->
-<div class="topNav"><a id="navbar.top">
+<div class="topNav"><a name="navbar.top">
Review comment:
seems like there are some changes to HTMLs not related to the version change. Have you tested out if the UI still displays correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org