You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Peter Liljenberg (JIRA)" <ji...@apache.org> on 2009/01/23 13:14:59 UTC

[jira] Created: (CXF-2000) ReadHeadersInterceptor ignoring DataBinding when creating SoapHeader

ReadHeadersInterceptor ignoring DataBinding when creating SoapHeader
--------------------------------------------------------------------

                 Key: CXF-2000
                 URL: https://issues.apache.org/jira/browse/CXF-2000
             Project: CXF
          Issue Type: Bug
          Components: Soap Binding
    Affects Versions: 2.1.2
            Reporter: Peter Liljenberg


We tried to use soapheaders by adding a HeaderProcessor. When looking at the CXF code (2.1.2) we find this in ReadHeadersInterceptor:

  HeaderProcessor p = bus.getExtension(HeaderManager.class)
                                .getHeaderProcessor(hel.getNamespaceURI());

 Object obj;
DataBinding dataBinding = null;
if (p == null || p.getDataBinding() == null) {
  obj = node;
} else {
   obj = p.getDataBinding().createReader(Node.class).read(node);
}
//TODO - add the interceptors
SoapHeader shead = new SoapHeader(new QName(node.getNamespaceURI(),node.getLocalName()), obj, dataBinding);

This looks like a bug to me.

Should the dataBinding that is extraced be used when constructing the SoapHeader instead of ALWAYS be null. I'm just guessing but shouldn't it look like this:

} else {
   dataBinding = p.getDataBinding();
   obj = dataBinding.createReader(Node.class).read(node); 


http://www.nabble.com/Bug-in-ReadHeadersInterceptor--td21621240.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-2000) ReadHeadersInterceptor ignoring DataBinding when creating SoapHeader

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-2000.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.4
                   2.0.10

> ReadHeadersInterceptor ignoring DataBinding when creating SoapHeader
> --------------------------------------------------------------------
>
>                 Key: CXF-2000
>                 URL: https://issues.apache.org/jira/browse/CXF-2000
>             Project: CXF
>          Issue Type: Bug
>          Components: Soap Binding
>    Affects Versions: 2.1.2
>            Reporter: Peter Liljenberg
>            Assignee: Daniel Kulp
>             Fix For: 2.0.10, 2.1.4
>
>
> We tried to use soapheaders by adding a HeaderProcessor. When looking at the CXF code (2.1.2) we find this in ReadHeadersInterceptor:
>   HeaderProcessor p = bus.getExtension(HeaderManager.class)
>                                 .getHeaderProcessor(hel.getNamespaceURI());
>  Object obj;
> DataBinding dataBinding = null;
> if (p == null || p.getDataBinding() == null) {
>   obj = node;
> } else {
>    obj = p.getDataBinding().createReader(Node.class).read(node);
> }
> //TODO - add the interceptors
> SoapHeader shead = new SoapHeader(new QName(node.getNamespaceURI(),node.getLocalName()), obj, dataBinding);
> This looks like a bug to me.
> Should the dataBinding that is extraced be used when constructing the SoapHeader instead of ALWAYS be null. I'm just guessing but shouldn't it look like this:
> } else {
>    dataBinding = p.getDataBinding();
>    obj = dataBinding.createReader(Node.class).read(node); 
> http://www.nabble.com/Bug-in-ReadHeadersInterceptor--td21621240.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CXF-2000) ReadHeadersInterceptor ignoring DataBinding when creating SoapHeader

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp reassigned CXF-2000:
--------------------------------

    Assignee: Daniel Kulp

> ReadHeadersInterceptor ignoring DataBinding when creating SoapHeader
> --------------------------------------------------------------------
>
>                 Key: CXF-2000
>                 URL: https://issues.apache.org/jira/browse/CXF-2000
>             Project: CXF
>          Issue Type: Bug
>          Components: Soap Binding
>    Affects Versions: 2.1.2
>            Reporter: Peter Liljenberg
>            Assignee: Daniel Kulp
>
> We tried to use soapheaders by adding a HeaderProcessor. When looking at the CXF code (2.1.2) we find this in ReadHeadersInterceptor:
>   HeaderProcessor p = bus.getExtension(HeaderManager.class)
>                                 .getHeaderProcessor(hel.getNamespaceURI());
>  Object obj;
> DataBinding dataBinding = null;
> if (p == null || p.getDataBinding() == null) {
>   obj = node;
> } else {
>    obj = p.getDataBinding().createReader(Node.class).read(node);
> }
> //TODO - add the interceptors
> SoapHeader shead = new SoapHeader(new QName(node.getNamespaceURI(),node.getLocalName()), obj, dataBinding);
> This looks like a bug to me.
> Should the dataBinding that is extraced be used when constructing the SoapHeader instead of ALWAYS be null. I'm just guessing but shouldn't it look like this:
> } else {
>    dataBinding = p.getDataBinding();
>    obj = dataBinding.createReader(Node.class).read(node); 
> http://www.nabble.com/Bug-in-ReadHeadersInterceptor--td21621240.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.