You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Gary Weaver (JIRA)" <ji...@apache.org> on 2009/08/27 19:50:59 UTC
[jira] Created: (PLUTO-576) Maven pluto plugin should fail or
generate warning if web.xml already contains servlet/servlet-mapping
similar to one being added by maven pluto plugin
Maven pluto plugin should fail or generate warning if web.xml already contains servlet/servlet-mapping similar to one being added by maven pluto plugin
-------------------------------------------------------------------------------------------------------------------------------------------------------
Key: PLUTO-576
URL: https://issues.apache.org/jira/browse/PLUTO-576
Project: Pluto
Issue Type: Improvement
Components: maven pluto plugin
Reporter: Gary Weaver
If the web.xml that the plugin is altering already contains a servlet and/or servlet-mapping element that looks very much like the ones it is adding it should either fail or at least generate a warning. I know that having the pluto-generated config in the web.xml of the portlet to be "plutofied" by the plugin is wrong, but if the plugin makes web.xml invalid because that info already exists, it seems like it should check for it. Please ignore this if it is an invalid request, but I remembered that it worked this way, it caused problems for at least a few people developing portlets for uPortal over the past 2 years reported on the JASIG uportal-user/portlet-dev lists, and Eric Dalquist just mentioned that perhaps this would be a good place to mention it also since uPortal now uses this plugin. Thanks, guys!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-576) Maven pluto plugin should fail or
generate warning if web.xml already contains servlet/servlet-mapping
similar to one being added by maven pluto plugin
Posted by "Gary Weaver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869641#action_12869641 ]
Gary Weaver commented on PLUTO-576:
-----------------------------------
I created a tool to clean up the changes made by Pluto to a war available here if anyone needs it:
* http://github.com/garysweaver/unplutofy
> Maven pluto plugin should fail or generate warning if web.xml already contains servlet/servlet-mapping similar to one being added by maven pluto plugin
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-576
> URL: https://issues.apache.org/jira/browse/PLUTO-576
> Project: Pluto
> Issue Type: Improvement
> Components: maven pluto plugin
> Reporter: Gary Weaver
>
> If the web.xml that the plugin is altering already contains a servlet and/or servlet-mapping element that looks very much like the ones it is adding it should either fail or at least generate a warning. I know that having the pluto-generated config in the web.xml of the portlet to be "plutofied" by the plugin is wrong, but if the plugin makes web.xml invalid because that info already exists, it seems like it should check for it. Please ignore this if it is an invalid request, but I remembered that it worked this way, it caused problems for at least a few people developing portlets for uPortal over the past 2 years reported on the JASIG uportal-user/portlet-dev lists, and Eric Dalquist just mentioned that perhaps this would be a good place to mention it also since uPortal now uses this plugin. Thanks, guys!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-576) Maven pluto plugin should fail or
generate warning if web.xml already contains servlet/servlet-mapping
similar to one being added by maven pluto plugin
Posted by "Gary Weaver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748487#action_12748487 ]
Gary Weaver commented on PLUTO-576:
-----------------------------------
Note Eric said "Perhaps a better enhancement for uPortal's purpose would be to fail with a message stating the web.xml should be cleaned out before the deploy tool is used."
> Maven pluto plugin should fail or generate warning if web.xml already contains servlet/servlet-mapping similar to one being added by maven pluto plugin
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PLUTO-576
> URL: https://issues.apache.org/jira/browse/PLUTO-576
> Project: Pluto
> Issue Type: Improvement
> Components: maven pluto plugin
> Reporter: Gary Weaver
>
> If the web.xml that the plugin is altering already contains a servlet and/or servlet-mapping element that looks very much like the ones it is adding it should either fail or at least generate a warning. I know that having the pluto-generated config in the web.xml of the portlet to be "plutofied" by the plugin is wrong, but if the plugin makes web.xml invalid because that info already exists, it seems like it should check for it. Please ignore this if it is an invalid request, but I remembered that it worked this way, it caused problems for at least a few people developing portlets for uPortal over the past 2 years reported on the JASIG uportal-user/portlet-dev lists, and Eric Dalquist just mentioned that perhaps this would be a good place to mention it also since uPortal now uses this plugin. Thanks, guys!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.