[jira] [Commented] (NIFI-6339) ListHDFS processor will list files without using previous state when cluster startup

["Peter Wicks (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856822#comment-16856822 ] 

Peter Wicks commented on NIFI-6339:
-----------------------------------

[~markap14]/[~bende], I was going to review this, but am not comfortable enough with the context of what this code does. Would appreciate your assistance.

> ListHDFS processor will list files without using previous state when cluster startup
> ------------------------------------------------------------------------------------
>
>                 Key: NIFI-6339
>                 URL: https://issues.apache.org/jira/browse/NIFI-6339
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.9.0, 1.9.1, 1.9.2
>            Reporter: Hsin-Ying Lee
>            Priority: Major
>         Attachments: NIFI-6339.v0.patch
>
>
> When the node startup, NiFi will create processor and load the property & state.
> But ListHDFS will ignore the previous listed-state stored on Zookeeper, and relist all file again.
>  
> And I found when we call the function setProperty, we only check the value between default and newValue. If oldValue is same with newValue, it'll also trigger function onPropertyModified.
> It casue ListHDFS loaclVariable: resetState to be true. When ListHDFS be triggered, it'll clear the state empty, and relist all the files in the directory.
>  
> {code:java}
> // AbstractComponentNode.java
> if (!value.equals(propertyModComparisonValue)) {
>     try {
>         onPropertyModified(descriptor, oldValue, value);
>     } catch (final Exception e) {
>         // nothing really to do here...
>     }
> }
> {code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)