[GitHub] [incubator-mxnet] bgawrych commented on a change in pull request #20505: If variable is not used within the loop body, start the name with an underscore

[GitBox <gi...@apache.org>]

bgawrych commented on a change in pull request #20505:
URL: https://github.com/apache/incubator-mxnet/pull/20505#discussion_r693931632



##########
File path: python/mxnet/gluon/contrib/estimator/estimator.py
##########
@@ -392,7 +392,7 @@ def fit(self, train_data,
             for handler in epoch_begin:
                 handler.epoch_begin(estimator_ref)
 
-            for i, batch in enumerate(train_data):
+            for _, batch in enumerate(train_data):

Review comment:
       in most of the cases enumerate makes no sense




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org