You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ozhera.apache.org by "sadadw1 (via GitHub)" <gi...@apache.org> on 2026/08/27 06:47:16 UTC
[PR] docs: fix broken JVM flags/path in best-practices deployment yaml (EN) [ozhera]
sadadw1 opened a new pull request, #686:
URL: https://github.com/apache/ozhera/pull/686
### Ⅰ. Describe what this PR did
Fixes three stray spaces in the YAML `command` arrays of `readme/best-practices/deployment.md` (EN) that broke JVM flags and a jar path:
```diff
- "-Duser .timezone=Asia/Shanghai",
+ "-Duser.timezone=Asia/Shanghai",
...
- "/home/work/trace-etl-es /trace-etl-es-1.0.0-SNAPSHOT.jar",
+ "/home/work/trace-etl-es/trace-etl-es-1.0.0-SNAPSHOT.jar",
...
- "-Dnacos. standalone=true",
+ "-Dnacos.standalone=true",
```
The CN counterpart (`deployment_cn.md`) already has the correct, unbroken text; this brings the EN version in line.
### Ⅱ. Does this pull request fix one issue?
fixes #685
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Documentation-only text fix inside a yaml code block; nothing to test.
### Ⅳ. Describe how to verify it
Diff the EN `command` lines against the CN `deployment_cn.md` lines (45, 53) — they should now match.
### Ⅴ. Special notes for reviews
Reference for the intended values: `readme/best-practices/deployment_cn.md` (correct).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ozhera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ozhera.apache.org
For additional commands, e-mail: commits-help@ozhera.apache.org
Re: [PR] docs: fix broken JVM flags/path in best-practices deployment yaml (EN) [ozhera]
Posted by "wtt40122 (via GitHub)" <gi...@apache.org>.
wtt40122 merged PR #686:
URL: https://github.com/apache/ozhera/pull/686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ozhera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ozhera.apache.org
For additional commands, e-mail: commits-help@ozhera.apache.org