You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/11 03:22:30 UTC

[GitHub] [doris] Henry2SS opened a new pull request, #11671: [Enhancement](profile print format) print fragment and instance in a better format

Henry2SS opened a new pull request, #11671:
URL: https://github.com/apache/doris/pull/11671

   # Proposed changes
   
   Issue Number: close #11669 
   
   ## Problem summary
   
   print fragment and instance in a better format
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Henry2SS commented on a diff in pull request #11671: [Enhancement](profile print format) print fragment and instance in a better format

Posted by GitBox <gi...@apache.org>.
Henry2SS commented on code in PR #11671:
URL: https://github.com/apache/doris/pull/11671#discussion_r943070378


##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreePrinter.java:
##########
@@ -35,6 +35,8 @@ public enum PrintLevel {
     public static String printFragmentTree(ProfileTreeNode root) {
         SimpleTreeNode rootNode = buildNode(root, PrintLevel.FRAGMENT);
         StringBuilder sb = new StringBuilder();
+        // for better format

Review Comment:
   Done. Thx~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #11671: [Enhancement](profile print format) print fragment and instance in a better format

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11671:
URL: https://github.com/apache/doris/pull/11671#issuecomment-1211521433

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #11671: [Enhancement](profile print format) print fragment and instance in a better format

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11671:
URL: https://github.com/apache/doris/pull/11671#issuecomment-1211521462

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] caiconghui merged pull request #11671: [Enhancement](profile print format) print fragment and instance in a better format

Posted by GitBox <gi...@apache.org>.
caiconghui merged PR #11671:
URL: https://github.com/apache/doris/pull/11671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] caiconghui commented on a diff in pull request #11671: [Enhancement](profile print format) print fragment and instance in a better format

Posted by GitBox <gi...@apache.org>.
caiconghui commented on code in PR #11671:
URL: https://github.com/apache/doris/pull/11671#discussion_r943069698


##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileTreePrinter.java:
##########
@@ -35,6 +35,8 @@ public enum PrintLevel {
     public static String printFragmentTree(ProfileTreeNode root) {
         SimpleTreeNode rootNode = buildNode(root, PrintLevel.FRAGMENT);
         StringBuilder sb = new StringBuilder();
+        // for better format

Review Comment:
   remove the comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org