You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 17:46:31 UTC

[PR] test: cover settings requirements, timeout bounds and mapping [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3520:
URL: https://github.com/apache/rocketmq-dashboard/pull/3520

   ### Summary
   
   `GeneralSettingsUpdateDTO` enforces required settings fields, bounds the session timeout and maps into a settings VO. It had no tests.
   
   ### Changes
   
   - A request missing the required settings fields reports violations for each
   - A session timeout outside 5–1440 is rejected
   - A complete request passes validation
   - `toSettings` carries the configured values through
   
   ### Testing
   
   `mvn test -Dtest=GeneralSettingsUpdateDTOTest` passes: 4 tests, 0 failures (first coverage for this DTO).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: cover settings requirements, timeout bounds and mapping [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3520: test: cover settings requirements, timeout bounds and mapping
URL: https://github.com/apache/rocketmq-dashboard/pull/3520


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org