[GitHub] [accumulo] Manno15 commented on a change in pull request #2133: Fix warnings in accumulo-cluster scrip

[GitBox <gi...@apache.org>]

Manno15 commented on a change in pull request #2133:
URL: https://github.com/apache/accumulo/pull/2133#discussion_r645026477



##########
File path: assemble/bin/accumulo-cluster
##########
@@ -235,21 +235,21 @@ function stop_tservers() {
 function kill_all() {
   echo "Killing Accumulo cluster..."
 
-  for manager in $(grep -v '^#' "${conf}/$manager_file"); do
+  grep -v '^#' "${conf}/$manager_file" | while read -r manager; do
     kill_service "$manager" manager
   done
 
-  for gc in $(grep -v '^#' "${conf}/gc"); do
+  grep -v '^#' "${conf}/gc" | while read -r gc; do
     kill_service "$gc" gc
   done
 
   kill_service "$monitor" monitor
 
-  for tracer in $(egrep -v '(^#|^\s*$)' "${conf}/tracers"); do
+  grep -Ev '(^#|^\s*$)' "${conf}/tracers" | while read -r tracer; do
     kill_service "$tracer" tracer
   done
 
-  for host in $(egrep -v '(^#|^\s*$)' "${conf}/tservers"); do
+  grep -Ev '(^#|^\s*$)' "${conf}/tservers" | while read -r server; do

Review comment:
       Good catch. Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org