[GitHub] [airflow] zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

[GitBox <gi...@apache.org>]

zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile
URL: https://github.com/apache/airflow/pull/7683#issuecomment-610174787
 
 
   > This does not look right to me - to put this button on task-level actions window. Wouldn’t it be better to put it on the DagRun actions window (when you click on the round colored button)?
   
   Hi @feluelle , we already have set state to `failed/running/success` in dagrun page. And this feature not trigger from dagrun, but trigger from Dag page when trying to make task failed/success, so I think it should not put in the DagRun page.
   
   This patch will check if all task in dagrun success or not, if all task success will change dagrun state to success, otherwise will keep in to failed.
   
   But I agree with you that it maybe confuse users, with dag in task windows, maybe we should make `include_dag` default `True` in `_mark_task_instance_state`
   
   ```py
           return self._mark_task_instance_state(dag_id, task_id, origin, execution_date,
                                                 confirmed, upstream, downstream,
                                                 future, past, State.FAILED)
                                                 future, past, include_dag=True, State.FAILED)
   ```
   and change the `UPDATING.md`. I'm left here wait for other committer advices.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services