You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/06/24 02:07:14 UTC
[kudu-CR] [ts itest-base] minor clean-up on BuildAndStart()
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7290
Change subject: [ts_itest-base] minor clean-up on BuildAndStart()
......................................................................
[ts_itest-base] minor clean-up on BuildAndStart()
Minor clean-up on TabletServerIntegrationTestBase::BuildAndStart() and
its usage in raft_consensus-itest, exactly_once_writes-itest, and
kudu-admin-test.
This patch does not contain any functional changes.
Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
---
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 207 insertions(+), 151 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7290/1
--
To view, visit http://gerrit.cloudera.org:8080/7290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [ts itest-base] minor clean-up on BuildAndStart()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [ts_itest-base] minor clean-up on BuildAndStart()
......................................................................
Patch Set 2: Code-Review+2
Carrying over Adar's +2 from PS1.
--
To view, visit http://gerrit.cloudera.org:8080/7290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [ts itest-base] minor clean-up on BuildAndStart()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7290
to look at the new patch set (#2).
Change subject: [ts_itest-base] minor clean-up on BuildAndStart()
......................................................................
[ts_itest-base] minor clean-up on BuildAndStart()
Minor clean-up on TabletServerIntegrationTestBase::BuildAndStart() and
its usage in raft_consensus-itest, exactly_once_writes-itest, and
kudu-admin-test.
This patch does not contain any functional changes.
Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
---
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 205 insertions(+), 149 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7290/2
--
To view, visit http://gerrit.cloudera.org:8080/7290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [ts itest-base] minor clean-up on BuildAndStart()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [ts_itest-base] minor clean-up on BuildAndStart()
......................................................................
Patch Set 2:
> Uploaded patch set 2.
Resolved the conflict with d5fe274dcdfa3e8716372e41266e00ccb6f769d5
--
To view, visit http://gerrit.cloudera.org:8080/7290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [ts itest-base] minor clean-up on BuildAndStart()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [ts_itest-base] minor clean-up on BuildAndStart()
......................................................................
[ts_itest-base] minor clean-up on BuildAndStart()
Minor clean-up on TabletServerIntegrationTestBase::BuildAndStart() and
its usage in raft_consensus-itest, exactly_once_writes-itest, and
kudu-admin-test.
This patch does not contain any functional changes.
Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
Reviewed-on: http://gerrit.cloudera.org:8080/7290
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 205 insertions(+), 149 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [ts itest-base] minor clean-up on BuildAndStart()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [ts_itest-base] minor clean-up on BuildAndStart()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7290
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I908db0f495170f899e47133fe877923cdf3aad21
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No