You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "holdenk (JIRA)" <ji...@apache.org> on 2016/07/28 23:39:20 UTC
[jira] [Comment Edited] (SPARK-16774) Fix use of deprecated
TimeStamp constructor (also providing incorrect results)
[ https://issues.apache.org/jira/browse/SPARK-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398424#comment-15398424 ]
holdenk edited comment on SPARK-16774 at 7/28/16 11:38 PM:
-----------------------------------------------------------
While diving into this (relatedly I hate timezones) - I'm pretty sure I've encountered a logic bug for our handling close to daylight savings boundaries - namely the inline comments suggest the timestamp is being constructed against UTC but careful reading of the JDK code indicates its actually using the system default. I'm going to add some tests around this and replace the fall-back code with the calendar based approach.
was (Author: holdenk):
While diving into this (relatedly I hate timezones) - I'm pretty sure I've encountered a logic bug for our handling close to timezone boundaries - namely the inline comments suggest the timestamp is being constructed against UTC but careful reading of the JDK code indicates its actually using the system default. I'm going to add some tests around this and replace the fall-back code with the calendar based approach.
> Fix use of deprecated TimeStamp constructor (also providing incorrect results)
> ------------------------------------------------------------------------------
>
> Key: SPARK-16774
> URL: https://issues.apache.org/jira/browse/SPARK-16774
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Reporter: holdenk
>
> The TimeStamp constructor we use inside of DateTime utils has been deprecated since JDK 1.1 - while Java does take a long time to remove deprecated functionality we might as well address this. Additionally it does not handle DST boundaries correctly all the time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org