You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ds...@apache.org on 2025/09/09 16:08:49 UTC

(tomcat) 02/08: Remove specific exception UnknownHostException as it's covered by general IOException and remove redundant initializer.

This is an automated email from the ASF dual-hosted git repository.

dsoumis pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 1522c56e78c010d6a56551aabfe868909ed1a20c
Author: Dimitris Soumis <ji...@gmail.com>
AuthorDate: Mon Sep 8 15:42:28 2025 +0300

    Remove specific exception UnknownHostException as it's covered by general IOException and remove redundant initializer.
---
 test/org/apache/catalina/manager/TestManagerWebapp.java | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/test/org/apache/catalina/manager/TestManagerWebapp.java b/test/org/apache/catalina/manager/TestManagerWebapp.java
index ad1a6b2d7c..f3a11be8cf 100644
--- a/test/org/apache/catalina/manager/TestManagerWebapp.java
+++ b/test/org/apache/catalina/manager/TestManagerWebapp.java
@@ -21,7 +21,6 @@ import java.io.FileReader;
 import java.io.IOException;
 import java.io.PrintWriter;
 import java.io.StringWriter;
-import java.net.UnknownHostException;
 import java.nio.charset.StandardCharsets;
 
 import jakarta.servlet.http.HttpServletResponse;
@@ -282,7 +281,7 @@ public class TestManagerWebapp extends TomcatBaseTest {
         SimpleHttpClient client = new SimpleHttpClient() {
             // 10s default too low for some CI systems
             @Override
-            public void connect() throws UnknownHostException, IOException {
+            public void connect() throws IOException {
                 connect(30000, 30000);
             }
 
@@ -403,7 +402,7 @@ public class TestManagerWebapp extends TomcatBaseTest {
         File serverXml = new File(tomcat.getServer().getCatalinaBase(), Catalina.SERVER_XML);
         Assert.assertTrue(serverXml.canRead());
         addDeleteOnTearDown(serverXml);
-        String serverXmlDump = "";
+        String serverXmlDump;
         try (FileReader reader = new FileReader(serverXml); StringWriter writer = new StringWriter()) {
             IOTools.flow(reader, writer);
             serverXmlDump = writer.toString();
@@ -548,7 +547,7 @@ public class TestManagerWebapp extends TomcatBaseTest {
         tomcat.start();
         SimpleHttpClient client = new SimpleHttpClient() {
             @Override
-            public void connect() throws UnknownHostException, IOException {
+            public void connect() throws IOException {
                 connect(30000, 30000);
             }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org