You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/07/08 00:21:20 UTC

Re: Review Request 34508: Sqoop2: Create infrastructure providers for hadoop, tomcat, and database providers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34508/
-----------------------------------------------------------

(Updated July 7, 2015, 10:21 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2366
    https://issues.apache.org/jira/browse/SQOOP-2366


Repository: sqoop-sqoop2


Description
-------

commit bd1fbb96d76cea7ec1a3039b73aa9553576166f1
Author: Abraham Elmahrek <ab...@apache.org>
Date:   Fri May 15 16:10:17 2015 -0700

    SQOOP-2364: Sqoop2: Provide test infrastructure base class for server tests

:000000 100644 0000000... e4481c4... A  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/DatabaseInfrastructureProvider.java
:000000 100644 0000000... 9a3db29... A  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/HadoopInfrastructureProvider.java
:000000 100644 0000000... 5b4f595... A  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java


Diffs (updated)
-----

  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/DatabaseInfrastructureProvider.java PRE-CREATION 
  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/HadoopInfrastructureProvider.java PRE-CREATION 
  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/InfrastructureProvider.java PRE-CREATION 
  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java PRE-CREATION 

Diff: https://reviews.apache.org/r/34508/diff/


Testing
-------

N/A


Thanks,

Abraham Elmahrek


Re: Review Request 34508: Sqoop2: Create infrastructure providers for hadoop, tomcat, and database providers

Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34508/#review90877
-----------------------------------------------------------

Ship it!


LGTM

- richard zhou


On July 7, 2015, 10:21 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34508/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 10:21 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2366
>     https://issues.apache.org/jira/browse/SQOOP-2366
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit bd1fbb96d76cea7ec1a3039b73aa9553576166f1
> Author: Abraham Elmahrek <ab...@apache.org>
> Date:   Fri May 15 16:10:17 2015 -0700
> 
>     SQOOP-2364: Sqoop2: Provide test infrastructure base class for server tests
> 
> :000000 100644 0000000... e4481c4... A  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/DatabaseInfrastructureProvider.java
> :000000 100644 0000000... 9a3db29... A  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/HadoopInfrastructureProvider.java
> :000000 100644 0000000... 5b4f595... A  test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java
> 
> 
> Diffs
> -----
> 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/providers/DatabaseInfrastructureProvider.java PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/providers/HadoopInfrastructureProvider.java PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/providers/InfrastructureProvider.java PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34508/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>