[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9025: [dashboard] fix, add config to optionally enable react replacement fo…

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #9025: [dashboard] fix, add config to optionally enable react replacement fo…
URL: https://github.com/apache/incubator-superset/pull/9025#discussion_r371363184
 
 

 ##########
 File path: superset/views/dashboard/views.py
 ##########
 @@ -40,6 +40,8 @@
 from ..utils import bootstrap_user_data
 from .mixin import DashboardMixin
 
+config = app.config
 
 Review comment:
   I think this is used for connivence though in general I’m not certain the abstraction is worth it. I would prefer we use `app.config[...]` on line #62. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org