You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "freemandealer (via GitHub)" <gi...@apache.org> on 2026/05/19 07:35:05 UTC

[PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

freemandealer opened a new pull request, #63394:
URL: https://github.com/apache/doris/pull/63394

   Issue Number: N/A
   
   Related PR: N/A
   
   Problem Summary: File cache hit ratio metrics are derived from global file cache read bytes, but warmup reads from manual warmup, periodic warmup, event-driven warmup, and rebalance-triggered warmup used to update the same counters as query reads. This polluted the query hit ratio. Mixed hit/miss reads could also be attributed to one source for the whole request. This change skips warmup updates to global file cache read metrics while preserving per-IOContext profile stats, records local/remote/peer bytes by actual returned bytes, and avoids updating metrics for failed reads. It also fixes direct-read partial continuation and no-warmup miss-only hit ratio refresh.
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4569769587

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4594578960

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 171704 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 89cd3d2ac6546f6e5d74348bd51055794c398023, data reload: false
   
   query5	4336	662	517	517
   query6	350	245	213	213
   query7	4300	581	320	320
   query8	330	230	227	227
   query9	8813	4069	4045	4045
   query10	479	364	310	310
   query11	5755	2360	2200	2200
   query12	191	134	125	125
   query13	1276	669	437	437
   query14	6105	5472	5177	5177
   query14_1	4483	4507	4511	4507
   query15	213	202	183	183
   query16	1015	438	450	438
   query17	984	737	596	596
   query18	2451	483	378	378
   query19	215	205	164	164
   query20	142	136	132	132
   query21	216	141	119	119
   query22	13715	13636	13473	13473
   query23	17566	16506	16250	16250
   query23_1	16242	16343	16364	16343
   query24	7414	1780	1318	1318
   query24_1	1325	1307	1326	1307
   query25	570	487	423	423
   query26	1296	318	172	172
   query27	2732	568	352	352
   query28	4514	2062	2017	2017
   query29	974	638	530	530
   query30	313	236	199	199
   query31	1156	1081	945	945
   query32	95	77	75	75
   query33	541	357	315	315
   query34	1205	1156	660	660
   query35	786	811	692	692
   query36	1390	1398	1224	1224
   query37	157	105	93	93
   query38	3235	3190	3069	3069
   query39	925	926	884	884
   query39_1	878	894	865	865
   query40	242	147	127	127
   query41	65	61	64	61
   query42	116	114	112	112
   query43	329	334	290	290
   query44	
   query45	216	205	199	199
   query46	1105	1187	712	712
   query47	2355	2367	2252	2252
   query48	376	430	291	291
   query49	642	502	400	400
   query50	1006	365	260	260
   query51	4400	4311	4290	4290
   query52	107	109	99	99
   query53	256	281	208	208
   query54	321	285	264	264
   query55	96	93	88	88
   query56	312	314	307	307
   query57	1437	1419	1334	1334
   query58	310	276	279	276
   query59	1607	1660	1394	1394
   query60	330	327	322	322
   query61	160	161	158	158
   query62	710	651	590	590
   query63	251	206	216	206
   query64	2411	894	630	630
   query65	
   query66	1750	486	366	366
   query67	29892	29749	29672	29672
   query68	
   query69	479	350	298	298
   query70	1077	1035	1035	1035
   query71	319	284	284	284
   query72	2999	2690	2505	2505
   query73	872	789	462	462
   query74	5162	5030	4766	4766
   query75	2718	2641	2313	2313
   query76	2320	1197	795	795
   query77	416	432	362	362
   query78	12500	12367	11887	11887
   query79	1284	1034	769	769
   query80	659	589	511	511
   query81	453	289	250	250
   query82	245	165	122	122
   query83	286	298	261	261
   query84	302	146	118	118
   query85	935	629	551	551
   query86	376	331	350	331
   query87	3425	3353	3255	3255
   query88	3639	2792	2720	2720
   query89	447	394	359	359
   query90	2151	197	185	185
   query91	197	186	159	159
   query92	87	80	80	80
   query93	1524	1456	914	914
   query94	528	345	318	318
   query95	704	398	363	363
   query96	1035	815	327	327
   query97	2712	2750	2584	2584
   query98	237	233	230	230
   query99	1143	1171	1032	1032
   Total cold run time: 253572 ms
   Total hot run time: 171704 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4533761604

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172239 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 2c3dbaf13fa2e8ca3efd05702ade9fece33285fb, data reload: false
   
   query5	4318	670	516	516
   query6	356	222	207	207
   query7	4258	517	300	300
   query8	323	244	221	221
   query9	8808	4235	4223	4223
   query10	448	346	301	301
   query11	5810	2559	2234	2234
   query12	174	128	127	127
   query13	1331	613	441	441
   query14	6159	5540	5252	5252
   query14_1	4552	4586	4467	4467
   query15	211	203	183	183
   query16	982	444	465	444
   query17	963	712	595	595
   query18	2435	475	344	344
   query19	214	195	158	158
   query20	139	131	129	129
   query21	218	134	119	119
   query22	13746	13588	13274	13274
   query23	17537	16620	16303	16303
   query23_1	16451	16318	16453	16318
   query24	7493	1814	1332	1332
   query24_1	1340	1333	1342	1333
   query25	537	466	412	412
   query26	1339	321	172	172
   query27	2695	567	363	363
   query28	4508	2093	2044	2044
   query29	977	617	494	494
   query30	313	241	234	234
   query31	1130	1067	944	944
   query32	85	75	82	75
   query33	532	358	300	300
   query34	1171	1204	673	673
   query35	774	791	679	679
   query36	1458	1415	1259	1259
   query37	155	103	88	88
   query38	3244	3145	3059	3059
   query39	926	937	894	894
   query39_1	879	880	910	880
   query40	223	149	126	126
   query41	69	65	64	64
   query42	113	124	110	110
   query43	340	339	302	302
   query44	
   query45	220	205	202	202
   query46	1074	1184	745	745
   query47	2430	2453	2261	2261
   query48	383	416	291	291
   query49	638	496	390	390
   query50	977	343	250	250
   query51	4345	4286	4297	4286
   query52	106	108	94	94
   query53	264	286	208	208
   query54	320	276	260	260
   query55	95	91	87	87
   query56	311	313	293	293
   query57	1430	1453	1363	1363
   query58	302	276	273	273
   query59	1649	1674	1454	1454
   query60	313	321	316	316
   query61	158	164	153	153
   query62	710	656	584	584
   query63	247	205	212	205
   query64	2447	810	637	637
   query65	
   query66	1723	490	363	363
   query67	30135	30035	29329	29329
   query68	
   query69	465	345	303	303
   query70	1075	949	965	949
   query71	307	271	269	269
   query72	3073	2729	2446	2446
   query73	871	767	429	429
   query74	5132	4913	4800	4800
   query75	2731	2642	2300	2300
   query76	2333	1176	815	815
   query77	428	428	356	356
   query78	12450	12399	11988	11988
   query79	1323	1085	801	801
   query80	633	576	500	500
   query81	448	287	248	248
   query82	238	161	125	125
   query83	282	292	256	256
   query84	292	151	121	121
   query85	968	536	454	454
   query86	375	347	314	314
   query87	3431	3405	3257	3257
   query88	3688	2770	2757	2757
   query89	435	392	344	344
   query90	2165	182	179	179
   query91	177	165	149	149
   query92	82	79	77	77
   query93	1521	1459	879	879
   query94	541	354	301	301
   query95	705	484	344	344
   query96	1091	812	357	357
   query97	2758	2750	2609	2609
   query98	242	231	230	230
   query99	1171	1183	1037	1037
   Total cold run time: 254346 ms
   Total hot run time: 172239 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4533701123

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 32057 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2c3dbaf13fa2e8ca3efd05702ade9fece33285fb, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17605	4128	4240	4128
   q2	q3	10789	1465	813	813
   q4	4705	481	347	347
   q5	7590	2377	2157	2157
   q6	238	180	141	141
   q7	973	805	654	654
   q8	9387	1859	1632	1632
   q9	5241	5005	5006	5005
   q10	6383	2199	1899	1899
   q11	451	279	254	254
   q12	642	431	300	300
   q13	18180	3730	2788	2788
   q14	271	266	235	235
   q15	q16	829	794	731	731
   q17	959	965	850	850
   q18	7053	5860	5548	5548
   q19	1173	1289	1183	1183
   q20	547	468	290	290
   q21	5815	2945	2787	2787
   q22	576	383	315	315
   Total cold run time: 99407 ms
   Total hot run time: 32057 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4831	5061	4905	4905
   q2	q3	4917	5492	4694	4694
   q4	2152	2241	1430	1430
   q5	5010	4764	4702	4702
   q6	232	179	133	133
   q7	1915	1774	1596	1596
   q8	2446	2235	2197	2197
   q9	7960	7519	7408	7408
   q10	4790	4740	4259	4259
   q11	576	410	369	369
   q12	750	748	547	547
   q13	3053	3396	2870	2870
   q14	285	281	251	251
   q15	q16	692	712	625	625
   q17	1333	1294	1299	1294
   q18	7211	6785	7146	6785
   q19	1143	1099	1136	1099
   q20	2237	2219	1963	1963
   q21	5353	4711	4539	4539
   q22	525	459	448	448
   Total cold run time: 57411 ms
   Total hot run time: 52114 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4494391533

   run beut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4487220634

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 169227 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit e6e8f7829c2fb8810a25f3aacbfe1f93ef1b68b5, data reload: false
   
   query5	4331	650	519	519
   query6	335	225	205	205
   query7	4300	548	287	287
   query8	324	254	224	224
   query9	8788	4008	4046	4008
   query10	474	340	314	314
   query11	5832	2367	2158	2158
   query12	185	127	123	123
   query13	1295	598	453	453
   query14	6019	5324	5069	5069
   query14_1	4357	4377	4316	4316
   query15	219	205	182	182
   query16	997	443	410	410
   query17	1059	748	623	623
   query18	2485	500	374	374
   query19	222	209	166	166
   query20	149	138	134	134
   query21	222	170	118	118
   query22	13690	13567	13318	13318
   query23	17192	16314	16031	16031
   query23_1	16128	16150	16125	16125
   query24	7451	1741	1310	1310
   query24_1	1276	1297	1284	1284
   query25	566	467	411	411
   query26	1300	318	172	172
   query27	2774	524	344	344
   query28	4452	1958	1926	1926
   query29	969	635	489	489
   query30	307	242	196	196
   query31	1121	1065	939	939
   query32	89	77	73	73
   query33	543	350	295	295
   query34	1178	1107	646	646
   query35	761	781	669	669
   query36	1366	1330	1184	1184
   query37	155	97	91	91
   query38	3196	3124	3028	3028
   query39	940	930	903	903
   query39_1	880	877	866	866
   query40	231	146	124	124
   query41	65	65	63	63
   query42	108	110	113	110
   query43	325	334	281	281
   query44	
   query45	212	201	195	195
   query46	1014	1230	718	718
   query47	2301	2365	2142	2142
   query48	402	396	302	302
   query49	630	487	387	387
   query50	968	344	257	257
   query51	4327	4265	4239	4239
   query52	104	104	93	93
   query53	249	275	206	206
   query54	304	279	256	256
   query55	92	91	84	84
   query56	297	309	296	296
   query57	1440	1437	1317	1317
   query58	311	283	284	283
   query59	1530	1627	1406	1406
   query60	338	331	315	315
   query61	184	183	182	182
   query62	678	636	576	576
   query63	248	203	209	203
   query64	2474	842	682	682
   query65	
   query66	1740	500	375	375
   query67	29913	29886	29214	29214
   query68	
   query69	457	344	308	308
   query70	1028	954	989	954
   query71	328	279	273	273
   query72	3047	2697	2396	2396
   query73	825	731	426	426
   query74	5076	4948	4697	4697
   query75	2657	2584	2295	2295
   query76	2272	1143	752	752
   query77	393	403	338	338
   query78	12236	12296	11592	11592
   query79	1436	1011	718	718
   query80	1325	543	453	453
   query81	537	277	237	237
   query82	1027	160	126	126
   query83	334	275	248	248
   query84	294	141	110	110
   query85	922	570	459	459
   query86	453	330	328	328
   query87	3431	3432	3246	3246
   query88	3514	2668	2650	2650
   query89	456	386	335	335
   query90	1915	179	180	179
   query91	184	169	138	138
   query92	80	76	76	76
   query93	1513	1510	903	903
   query94	718	334	319	319
   query95	656	478	341	341
   query96	981	822	336	336
   query97	2713	2750	2580	2580
   query98	245	238	227	227
   query99	1146	1102	981	981
   Total cold run time: 253462 ms
   Total hot run time: 169227 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4545328479

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172307 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c0c2b8ded30b3fe37be05f290dd806e6f2888d77, data reload: false
   
   query5	4311	660	540	540
   query6	331	220	207	207
   query7	4226	543	300	300
   query8	333	238	215	215
   query9	8840	4111	4099	4099
   query10	481	356	304	304
   query11	5785	2443	2239	2239
   query12	185	130	127	127
   query13	1293	597	422	422
   query14	6119	5487	5200	5200
   query14_1	4489	4506	4458	4458
   query15	213	206	186	186
   query16	1028	478	425	425
   query17	1129	726	615	615
   query18	2670	502	353	353
   query19	215	210	164	164
   query20	138	132	128	128
   query21	218	143	121	121
   query22	13631	13637	13463	13463
   query23	17405	16692	16387	16387
   query23_1	16420	16528	16407	16407
   query24	7480	1808	1321	1321
   query24_1	1341	1338	1356	1338
   query25	583	503	450	450
   query26	1300	334	179	179
   query27	2664	579	347	347
   query28	4421	2026	2004	2004
   query29	1039	664	535	535
   query30	305	244	201	201
   query31	1130	1083	962	962
   query32	93	77	77	77
   query33	550	396	308	308
   query34	1186	1140	641	641
   query35	789	806	703	703
   query36	1394	1429	1272	1272
   query37	153	102	92	92
   query38	3226	3181	3081	3081
   query39	939	931	892	892
   query39_1	884	879	881	879
   query40	231	151	131	131
   query41	70	70	67	67
   query42	113	114	113	113
   query43	333	340	306	306
   query44	
   query45	218	207	204	204
   query46	1087	1192	764	764
   query47	2416	2392	2278	2278
   query48	408	418	308	308
   query49	645	510	402	402
   query50	951	346	269	269
   query51	4422	4354	4268	4268
   query52	112	109	96	96
   query53	265	276	204	204
   query54	330	310	280	280
   query55	104	100	87	87
   query56	318	352	324	324
   query57	1482	1451	1320	1320
   query58	313	281	307	281
   query59	1632	1724	1474	1474
   query60	339	374	312	312
   query61	151	166	162	162
   query62	700	662	586	586
   query63	240	194	204	194
   query64	2362	812	639	639
   query65	
   query66	1712	476	347	347
   query67	29824	29737	29606	29606
   query68	
   query69	469	337	306	306
   query70	1058	1034	983	983
   query71	302	274	253	253
   query72	2992	2855	2467	2467
   query73	860	786	445	445
   query74	5153	5040	4804	4804
   query75	2688	2610	2266	2266
   query76	2310	1156	763	763
   query77	404	409	345	345
   query78	12494	12440	11764	11764
   query79	1477	990	764	764
   query80	779	582	438	438
   query81	478	279	239	239
   query82	1370	159	122	122
   query83	345	276	247	247
   query84	258	146	110	110
   query85	938	525	448	448
   query86	461	351	308	308
   query87	3465	3378	3259	3259
   query88	3588	2680	2734	2680
   query89	460	391	344	344
   query90	1770	180	181	180
   query91	179	166	138	138
   query92	76	82	73	73
   query93	1472	1367	882	882
   query94	635	372	312	312
   query95	697	473	352	352
   query96	1006	783	332	332
   query97	2734	2747	2672	2672
   query98	240	236	236	236
   query99	1187	1172	1040	1040
   Total cold run time: 254953 ms
   Total hot run time: 172307 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4571358004

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 171253 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit e024d85c88bca2fc83c42567dc0cbb83eb962d60, data reload: false
   
   query5	4321	662	514	514
   query6	334	223	200	200
   query7	4253	532	318	318
   query8	332	230	217	217
   query9	8789	4084	4089	4084
   query10	458	348	295	295
   query11	5765	2415	2191	2191
   query12	184	128	122	122
   query13	1252	618	420	420
   query14	6127	5453	5183	5183
   query14_1	4445	4446	4489	4446
   query15	208	204	182	182
   query16	1029	447	434	434
   query17	1141	712	579	579
   query18	2485	481	351	351
   query19	215	197	162	162
   query20	134	132	136	132
   query21	213	137	114	114
   query22	13570	13601	13407	13407
   query23	17232	16556	16155	16155
   query23_1	16267	16273	16274	16273
   query24	7420	1778	1344	1344
   query24_1	1318	1310	1318	1310
   query25	535	490	417	417
   query26	1351	319	179	179
   query27	2657	561	344	344
   query28	4448	2047	2013	2013
   query29	1027	654	524	524
   query30	303	239	207	207
   query31	1150	1073	962	962
   query32	108	82	76	76
   query33	549	366	312	312
   query34	1168	1155	664	664
   query35	814	799	716	716
   query36	1405	1441	1287	1287
   query37	163	105	89	89
   query38	3192	3199	3043	3043
   query39	948	928	900	900
   query39_1	892	880	899	880
   query40	227	152	129	129
   query41	72	67	67	67
   query42	116	122	112	112
   query43	330	326	300	300
   query44	
   query45	219	208	205	205
   query46	1127	1168	740	740
   query47	2338	2412	2230	2230
   query48	422	407	307	307
   query49	663	514	402	402
   query50	960	353	258	258
   query51	4372	4350	4253	4253
   query52	116	107	98	98
   query53	258	287	206	206
   query54	334	295	278	278
   query55	98	94	89	89
   query56	333	333	317	317
   query57	1450	1430	1364	1364
   query58	311	288	289	288
   query59	1586	1684	1435	1435
   query60	329	352	325	325
   query61	187	185	185	185
   query62	707	654	588	588
   query63	256	209	210	209
   query64	2469	815	638	638
   query65	
   query66	1749	493	370	370
   query67	29738	29092	29558	29092
   query68	
   query69	475	351	306	306
   query70	1057	1008	948	948
   query71	306	280	268	268
   query72	2931	2731	2653	2653
   query73	844	737	431	431
   query74	5156	4930	4785	4785
   query75	2697	2611	2254	2254
   query76	2283	1199	806	806
   query77	409	413	342	342
   query78	12397	12384	11899	11899
   query79	1524	999	742	742
   query80	785	540	455	455
   query81	474	277	242	242
   query82	1335	157	121	121
   query83	349	283	254	254
   query84	254	140	110	110
   query85	935	543	463	463
   query86	440	340	325	325
   query87	3475	3402	3238	3238
   query88	3638	2741	2728	2728
   query89	460	396	345	345
   query90	1816	179	191	179
   query91	183	166	147	147
   query92	79	82	76	76
   query93	1546	1493	900	900
   query94	610	361	304	304
   query95	695	411	352	352
   query96	1080	792	348	348
   query97	2717	2726	2605	2605
   query98	248	229	252	229
   query99	1149	1156	1043	1043
   Total cold run time: 254293 ms
   Total hot run time: 171253 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4595568609

   # BE Regression && UT Coverage Report
   Increment line coverage `92.22% (83/90)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63394_89cd3d2ac6546f6e5d74348bd51055794c398023_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63394_89cd3d2ac6546f6e5d74348bd51055794c398023_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 72.06% (27464/38115) |
   | Line Coverage     | 55.43% (293313/529121) |
   | Region Coverage   | 52.38% (243938/465735) |
   | Branch Coverage   | 53.69% (105079/195731) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer merged PR #63394:
URL: https://github.com/apache/doris/pull/63394


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4569770543

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4532991936

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4571279119

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31979 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit e024d85c88bca2fc83c42567dc0cbb83eb962d60, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17676	4252	4225	4225
   q2	q3	10736	1431	824	824
   q4	4711	470	340	340
   q5	8207	2320	2118	2118
   q6	387	177	142	142
   q7	1007	780	651	651
   q8	9585	1708	1686	1686
   q9	7154	4980	5008	4980
   q10	6493	2256	1886	1886
   q11	437	285	244	244
   q12	691	425	293	293
   q13	18198	3461	2788	2788
   q14	270	259	250	250
   q15	q16	820	782	714	714
   q17	917	870	886	870
   q18	7408	5821	5882	5821
   q19	1318	1355	1119	1119
   q20	563	413	264	264
   q21	6345	2798	2452	2452
   q22	457	391	312	312
   Total cold run time: 103380 ms
   Total hot run time: 31979 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	5012	5216	5000	5000
   q2	q3	4935	5310	4616	4616
   q4	2189	2250	1422	1422
   q5	4845	4736	4835	4736
   q6	240	182	125	125
   q7	1851	1660	1496	1496
   q8	2271	1930	2031	1930
   q9	7496	7366	7503	7366
   q10	4733	4681	4239	4239
   q11	567	410	380	380
   q12	737	747	567	567
   q13	3161	3364	2810	2810
   q14	273	273	248	248
   q15	q16	678	704	612	612
   q17	1317	1294	1294	1294
   q18	7499	6848	6942	6848
   q19	1140	1082	1088	1082
   q20	2245	2249	1954	1954
   q21	5305	4678	4471	4471
   q22	544	458	417	417
   Total cold run time: 57038 ms
   Total hot run time: 51613 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4560779323

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4487144965

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31237 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit e6e8f7829c2fb8810a25f3aacbfe1f93ef1b68b5, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17659	3964	3883	3883
   q2	q3	10761	1403	816	816
   q4	4684	476	350	350
   q5	7571	2363	2153	2153
   q6	337	177	139	139
   q7	974	792	637	637
   q8	9341	1840	1700	1700
   q9	6873	4925	4920	4920
   q10	6458	2115	1837	1837
   q11	448	274	244	244
   q12	694	430	303	303
   q13	18195	3449	2799	2799
   q14	260	259	236	236
   q15	q16	815	781	714	714
   q17	953	914	950	914
   q18	6900	5719	5579	5579
   q19	1138	1300	1074	1074
   q20	501	415	257	257
   q21	5749	2528	2377	2377
   q22	425	362	305	305
   Total cold run time: 100736 ms
   Total hot run time: 31237 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4260	4186	4187	4186
   q2	q3	4514	4980	4348	4348
   q4	2111	2197	1381	1381
   q5	4615	4311	4302	4302
   q6	353	234	162	162
   q7	1937	1854	1636	1636
   q8	2501	2070	2178	2070
   q9	7988	7830	7643	7643
   q10	4531	4483	4109	4109
   q11	597	614	379	379
   q12	731	731	519	519
   q13	3244	3637	3016	3016
   q14	312	316	292	292
   q15	q16	741	733	626	626
   q17	1353	1314	1303	1303
   q18	7994	7317	7135	7135
   q19	1131	1088	1066	1066
   q20	2210	2202	1914	1914
   q21	5285	4606	4471	4471
   q22	520	478	401	401
   Total cold run time: 56928 ms
   Total hot run time: 50959 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4544189583

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4600885858

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4485456804

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4494392075

   run nonConcurrent


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4593642605

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4595089575

   # BE UT Coverage Report
   Increment line coverage `82.22% (74/90)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/89cd3d2ac6546f6e5d74348bd51055794c398023_89cd3d2ac6546f6e5d74348bd51055794c398023/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/89cd3d2ac6546f6e5d74348bd51055794c398023_89cd3d2ac6546f6e5d74348bd51055794c398023/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 54.11% (21061/38926) |
   | Line Coverage     | 37.61% (199528/530498) |
   | Region Coverage   | 33.88% (156284/461308) |
   | Branch Coverage   | 34.84% (67941/194981) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "freemandealer (via GitHub)" <gi...@apache.org>.
freemandealer commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4598484757

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4594498490

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29466 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 89cd3d2ac6546f6e5d74348bd51055794c398023, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17614	4095	4035	4035
   q2	q3	10778	1430	831	831
   q4	4688	478	356	356
   q5	7566	892	600	600
   q6	183	195	137	137
   q7	794	857	690	690
   q8	9419	1684	1625	1625
   q9	5948	4574	4556	4556
   q10	6758	1829	1552	1552
   q11	444	275	256	256
   q12	630	433	296	296
   q13	18116	3576	2854	2854
   q14	262	262	238	238
   q15	q16	824	795	714	714
   q17	953	925	962	925
   q18	6893	5738	5643	5643
   q19	1309	1299	1025	1025
   q20	516	405	263	263
   q21	5919	2588	2571	2571
   q22	446	361	299	299
   Total cold run time: 100060 ms
   Total hot run time: 29466 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4358	4273	4278	4273
   q2	q3	4574	4976	4380	4380
   q4	2100	2198	1387	1387
   q5	4519	4342	4356	4342
   q6	227	179	132	132
   q7	1754	1781	1854	1781
   q8	2685	2243	2253	2243
   q9	8203	8398	7937	7937
   q10	4857	4792	4272	4272
   q11	569	410	380	380
   q12	761	783	542	542
   q13	3314	3714	2915	2915
   q14	318	307	298	298
   q15	q16	709	756	652	652
   q17	1344	1335	1309	1309
   q18	8397	7296	7458	7296
   q19	1208	1139	1174	1139
   q20	2246	2220	1943	1943
   q21	5286	4625	4452	4452
   q22	538	461	412	412
   Total cold run time: 57967 ms
   Total hot run time: 52085 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4485456897

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4560779535

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](filecache) exclude warmup reads from file cache hit ratio metrics [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63394:
URL: https://github.com/apache/doris/pull/63394#issuecomment-4545215979

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31251 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c0c2b8ded30b3fe37be05f290dd806e6f2888d77, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17609	4002	4011	4002
   q2	q3	10782	1483	819	819
   q4	4727	475	361	361
   q5	8819	2324	2085	2085
   q6	423	179	138	138
   q7	982	767	652	652
   q8	9407	1711	1645	1645
   q9	7091	5062	4999	4999
   q10	6472	2320	1899	1899
   q11	433	272	253	253
   q12	689	428	294	294
   q13	18222	3487	2778	2778
   q14	266	250	240	240
   q15	q16	828	805	711	711
   q17	930	1004	873	873
   q18	7276	5694	5505	5505
   q19	1206	1245	1065	1065
   q20	523	406	263	263
   q21	5756	2657	2369	2369
   q22	432	362	300	300
   Total cold run time: 102873 ms
   Total hot run time: 31251 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4376	4274	4283	4274
   q2	q3	4566	4973	4359	4359
   q4	2120	2233	1416	1416
   q5	4413	4298	5242	4298
   q6	257	194	140	140
   q7	1942	1838	1658	1658
   q8	2483	2214	2132	2132
   q9	8105	8177	7999	7999
   q10	4866	4857	4357	4357
   q11	607	417	389	389
   q12	796	768	561	561
   q13	3276	3624	2902	2902
   q14	313	304	277	277
   q15	q16	724	743	650	650
   q17	1390	1362	1359	1359
   q18	7892	7380	6824	6824
   q19	1126	1062	1151	1062
   q20	2241	2235	1969	1969
   q21	5358	4676	4463	4463
   q22	522	479	423	423
   Total cold run time: 57373 ms
   Total hot run time: 51512 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org