[jira] [Comment Edited] (NET-465) FTPClient setSendBufferSize and setReceiveBufferSize on data socket

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NET-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560936#comment-13560936 ] 

Sebb edited comment on NET-465 at 1/23/13 7:02 PM:
---------------------------------------------------

In retrospect it would have been better to provide additional getters/setters for the Socket size, as the requirements are quite different.

It's unfortunate that the Javadoc suggests that the buffer size applies to the sockets, whereas it was originally applied to the buffered streams.

Since the socket size is currently only set when the socket is created, a (messy) work-round with the existing code is to set the desired socket size, create the socket, and then immediately reset the size to a value more suitable for the buffered streams.
                
      was (Author: sebb@apache.org):
    In retrospect it would have been better to provide additional getters/setters for the Socket, as the requirements are quite different.
                  
> FTPClient setSendBufferSize and setReceiveBufferSize on data socket
> -------------------------------------------------------------------
>
>                 Key: NET-465
>                 URL: https://issues.apache.org/jira/browse/NET-465
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.1
>         Environment: All
>            Reporter: Jim Kerwood
>             Fix For: 3.2
>
>         Attachments: ftp-bufsize.diff
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> When sending large files the need to set the send and receive buffer sizes on the data socket is much more important than the command socket.  Please either give 2 more setters or make the setters set the data socket and leave the command socket alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira