[GitHub] [systemds] DavidSandruTU commented on pull request #1357: [WIP] Clean-up of the performance test suites for binomial, multinomial and regression benchmarks

[GitBox <gi...@apache.org>]

DavidSandruTU commented on pull request #1357:
URL: https://github.com/apache/systemds/pull/1357#issuecomment-892709681


   Thank you for your time @mboehm7.
   Yes, the correct github account for the commit is @DavidSandruTU, my student account.
   
   I think I should be done now, but a couple of things I want to address, let me know what you think:
   - In the end, I've removed all comments from the DML scripts, as they are intended to be ran by perftest only anyways. Let me know if I should revert the commit/keep some parts of the comments in. 
   - I've left in the logic for scoring in the perftest prediction dml scripts. Did you want me to remove that too? 
   - The matrix mult and transpose scripts are commented out and are not adapted to run a specified command (they run "systemds" by default). Should I change that?
   
   The pull request should be otherwise ready for merge, if these are all non-issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org