You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2019/07/08 12:59:30 UTC

[GitHub] [incubator-pagespeed-mod] oschaaf commented on issue #1908: Added brotli_enc and brotli_dec library targets to third party bazel build

oschaaf commented on issue #1908: Added brotli_enc and brotli_dec library targets to third party bazel build
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1908#issuecomment-509215014
 
 
   This doesn't build because of some warnings, and we're pretty much in super-strict mode.
   This change LGTM, I'll look into
   - See if we can apply `--copt -Wno-implicit-fallthrough` to the build of just this depedency
   - Add the bazel build to travis CI
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services