You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/10 23:46:30 UTC
[GitHub] [iceberg] rdblue commented on a diff in pull request #4943: Flink: add an option to set monitoring snapshot number
rdblue commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r894944629
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -143,7 +147,26 @@ public void run(SourceContext<FlinkInputSplit> ctx) throws Exception {
}
}
- private void monitorAndForwardSplits() {
+ private long maxReachableSnapshotId(long lastConsumedSnapshotId, long latestSnapshotId,
+ int maxSnapshotCountPerMonitorInterval) {
+ // This doesn't consider snapshot inheritance since it is already checked in state initialization.
Review Comment:
What do you mean by "snapshot inheritance" here?
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -143,7 +147,26 @@ public void run(SourceContext<FlinkInputSplit> ctx) throws Exception {
}
}
- private void monitorAndForwardSplits() {
+ private long maxReachableSnapshotId(long lastConsumedSnapshotId, long latestSnapshotId,
+ int maxSnapshotCountPerMonitorInterval) {
Review Comment:
I think this should be `maxSnapshots`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org