You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/05/13 13:05:52 UTC

[GitHub] [avro] martin-g opened a new pull request, #1685: AVRO-3512: Fix the aliases' namespace when parsing named schemata

martin-g opened a new pull request, #1685:
URL: https://github.com/apache/avro/pull/1685

   ### Jira
   
   - [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-3512
   
   ### Tests
   
   - [X] My PR adds new unit tests
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] A typo is fixed in the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g merged pull request #1685: AVRO-3512: Fix the aliases' namespace when parsing named schemata

Posted by GitBox <gi...@apache.org>.
martin-g merged PR #1685:
URL: https://github.com/apache/avro/pull/1685


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1685: AVRO-3512: Fix the aliases' namespace when parsing named schemata

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1685:
URL: https://github.com/apache/avro/pull/1685#issuecomment-1127311267

   I will extract the "Alias is a Name" to a separate issue/PR. It is a bigger change that is not really related to this issue/PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1685: AVRO-3512: Fix the aliases' namespace when parsing named schemata

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1685:
URL: https://github.com/apache/avro/pull/1685#issuecomment-1126036967

   // CC @jklamer @radai-rosenblatt 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1685: AVRO-3512: Fix the aliases' namespace when parsing named schemata

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1685:
URL: https://github.com/apache/avro/pull/1685#issuecomment-1126390216

   > I'm wondering if the aliases are all fully qualified names then we should store them in a 'Name' struct? Not sure upsides or downsides though
   
   I like the idea! Let's try it and see!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] radai-rosenblatt commented on pull request #1685: AVRO-3512: Fix the aliases' namespace when parsing named schemata

Posted by GitBox <gi...@apache.org>.
radai-rosenblatt commented on PR #1685:
URL: https://github.com/apache/avro/pull/1685#issuecomment-1126214594

   looks OK to me and my lack of familiarity with rust :-)
   
   my only concern is i still dont know if aliases into the null namespace are a bug or a feature. 
   personally i definitely think they should be a feature (and i have used them at work before), but there's been no response on my issue yet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1685: AVRO-3512: Fix the aliases' namespace when parsing named schemata

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #1685:
URL: https://github.com/apache/avro/pull/1685#issuecomment-1127639076

   I am going to merge this PR even without the confirmation of the current Java behavior in the JIRA ticket.
   I will adapt it later if the Java impl changes!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org